commit 71c573ae67b6a15c33ad1036b37b999c54d7236b
author Chienyuan <chienyuanhuang@google.com> Fri Feb 19 20:05:20 2021 +0800
committer Chienyuan Huang <chienyuanhuang@google.com> Thu Mar 11 12:43:16 2021 +0000
tree 33b553a9c119f112e2d7606863736ce084c5f75d
parent b2d9ae364060a5229e4b268597156acf879eb832

AVRCP: pass bdaddr by value when use SdpCb

TAG: #security
Bug: 174182139
Test: compilation
Ignore-AOSP-First: security fix
Change-Id: I7f5b2a3dd0540a922b64ce213d871d355bd6dac6
Merged-In: I7f5b2a3dd0540a922b64ce213d871d355bd6dac6

profile/avrcp/connection_handler.cc

diff --git a/profile/avrcp/connection_handler.cc b/profile/avrcp/connection_handler.cc
index af8fb57..06c61b3 100644
--- a/profile/avrcp/connection_handler.cc
+++ b/profile/avrcp/connection_handler.cc
@@ -406,7 +406,7 @@
   device_map_[handle]->MessageReceived(label, Packet::Parse(pkt));
 }
 
-void ConnectionHandler::SdpCb(const RawAddress& bdaddr, SdpCallback cb,
+void ConnectionHandler::SdpCb(RawAddress bdaddr, SdpCallback cb,
                               tSDP_DISCOVERY_DB* disc_db, bool retry,
                               uint16_t status) {
   LOG(INFO) << __PRETTY_FUNCTION__ << ": SDP lookup callback received";

profile/avrcp/connection_handler.h

diff --git a/profile/avrcp/connection_handler.h b/profile/avrcp/connection_handler.h
index d5f0a27..a5029cf 100644
--- a/profile/avrcp/connection_handler.h
+++ b/profile/avrcp/connection_handler.h
@@ -136,7 +136,7 @@
   using SdpCallback = base::Callback<void(uint16_t status, uint16_t version,
                                           uint16_t features)>;
   virtual bool SdpLookup(const RawAddress& bdaddr, SdpCallback cb, bool retry);
-  void SdpCb(const RawAddress& bdaddr, SdpCallback cb,
+  void SdpCb(RawAddress bdaddr, SdpCallback cb,
              tSDP_DISCOVERY_DB* disc_db, bool retry, uint16_t status);
 
   virtual bool AvrcpConnect(bool initiator, const RawAddress& bdaddr);