commit 59c234a8fddda37147bb3fe1dd3b3a668828bcab
author Joseph Pirozzo <pirozzoj@google.com> Mon May 25 10:36:26 2020 -0700
committer Joseph Pirozzo <pirozzoj@google.com> Mon May 25 17:48:01 2020 +0000
tree 8f8c67ac303e33daae04c392636888ffad3b3681
parent 1570b62c88d7c5b9c6bfe43da8cc16ea30d3e8df

Enable bitpool sanity checks

Enable bitpool sanity checks to run all the time, not just in debug
mode.

Tag: #security
Test: sbcdecoder_fuzzer
Bug: 146398979
Change-Id: Iff58305cd18de35e37290f0c09fba01ee14e787a

embdrv/sbc/decoder/srce/decoder-sbc.c

diff --git a/embdrv/sbc/decoder/srce/decoder-sbc.c b/embdrv/sbc/decoder/srce/decoder-sbc.c
index 85c37d6..0fee49e 100644
--- a/embdrv/sbc/decoder/srce/decoder-sbc.c
+++ b/embdrv/sbc/decoder/srce/decoder-sbc.c
@@ -311,7 +311,6 @@
     return OI_CODEC_SBC_CHECKSUM_MISMATCH;
   }
 
-#ifdef OI_DEBUG
   /*
    * Make sure the bitpool values are sane.
    */
@@ -328,7 +327,6 @@
            OI_SBC_MaxBitpool(&context->common.frameInfo)));
     return OI_STATUS_INVALID_PARAMETERS;
   }
-#endif
 
   /*
    * Now decode the SBC data. Partial decode is not yet implemented for an SBC