| commit | 07f612cbc08364a622e6e02cdbb039b82586d82c | [log] [tgz] |
|---|---|---|
| author | Srinu Jella <sjella@codeaurora.org> | Tue Dec 29 13:30:19 2015 +0530 |
| committer | Andre Eisenbach <eisenbach@google.com> | Fri Mar 04 06:53:17 2016 +0000 |
| tree | 4cc5fffcac1838468bdf33d74ad8d8ad5b40b468 | |
| parent | cd0199a20b48fcb191f3178a28a6a503e28b7685 [diff] |
Avoid double-free on SDP search failure
Use case: BT transfer fails in Doze mode.
Pre-condition:
1. Device is in Doze mode.
2. Device is in Active state.
Steps to reproduce:
1. On test device and support device, turn on Bluetooth and keep test device in Bluetooth on screen.
2. Put device in Doze mode:
adb shell dumpsys battery unplug
adb shell dumpsys deviceidle step
3. From support device send pair request to test device.
4. Pair two devices.
5. Put test device in Doze mode again.
6. Share one picture from support device to test device by Bluetooth.
7. Accept Bluetooth file transferring request.
Failure: From DUT, BT transfer is failed.
Root cause: Free buffer is called twice for the SDP search failure case.
Fix: Added null check for p_sdp_db to avoid freeing same buffer
again on SDP search failure.
Change-Id: Ic7776e842c52418c2b0fb6d6479233d01c709dc2
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 15.10 with GCC 5.2.1.
sudo apt-get install libevent-dev
sudo apt-get install ninja-build
or download binary from https://github.com/ninja-build/ninja/releases
Get sha1 of current version from here and then download corresponding executable:
wget -O gn http://storage.googleapis.com/chromium-gn/<gn.sha1>
i.e. if sha1 is “3491f6687bd9f19946035700eb84ce3eed18c5fa” (value from 24 Feb 2016) do
wget -O gn http://storage.googleapis.com/chromium-gn/3491f6687bd9f19946035700eb84ce3eed18c5fa
Then make binary executable and put it on your PATH, i.e.:
chmod a+x ./gn sudo mv ./gn /usr/bin
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/modp_b64
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
Fluoride currently has dependency on some internal Android projects, which also need to be downloaded. This will be removed in future:
cd ~/fluoride git clone https://android.googlesource.com/platform/system/core git clone https://android.googlesource.com/platform/hardware/libhardware git clone https://android.googlesource.com/platform/system/media
We need to configure some paths to make the build successful. Run:
cd ~/fluoride/bt gn args out/Default
This will prompt you to fill the contents of your “out/Default/args.gn” file. Make it look like below. Replace “/home/job” with path to your home directory, and don't use “~” in build arguments:
# Build arguments go here. Examples: # is_component_build = true # is_debug = false # See "gn args <out_dir> --list" for available build arguments. libhw_include_path = "/home/job/fluoride/libhardware/include" core_include_path = "/home/job/fluoride/core/include" audio_include_path = "/home/job/fluoride/media/audio/include"
Then generate your build files by calling
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace “all” with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride