tree 0e593aaadf3a4cf6a18be079caaeed2fde316973
parent d81668725d81d6b3020b08e6fbc72acf3dc1c0c8
author Konstantinos Menychtas <kmenychtas@google.com> 1437173553 -0700
committer Konstantinos Menychtas <kmenychtas@google.com> 1437497807 +0000

DO NOT MERGE opengl: Fix QemuPipeStream::readFully reading beyond end of buffer

--- This is a back-port of AOSP change 4a7e93da by Yu Ning; the description of the original patch follows below ---

When GPU emulation is enabled, the emulator sometimes freezes, with an
error message in logcat similar to the following:

 QemuPipeStream::readFully failed (buf 0x7f9cd8ab8000): Bad address

Some users have reported the same issue, e.g.:

 https://code.google.com/p/android/issues/detail?id=170633

The root cause is that QemuPipeStream::readFully(void *buf, size_t len)
may attempt to read beyond (buf + len), resulting in a -EFAULT return
value from the goldfish/qemu pipe driver.

Fix this bug to improve the stability of the emulator. In addition,

 - Add more information to the said error message to facilitate future
   debugging.
 - Use "%zu" instead of "%d" for logging size_t variables.

Change-Id: I8785fee0427fd6c0f25237470b346e769a82c992
Signed-off-by: Yu Ning <yu.ning@intel.com>
Signed-off-by: Pengcheng Chen <pengcheng.chen@intel.com>