Google Git
Sign in
android / platform / prebuilts / checkstyle / f97db17303caf83e43793bfa4667563938d02aaf
commitf97db17303caf83e43793bfa4667563938d02aaf[log] [tgz]
authorSam Saccone <samccone@google.com>Fri Jul 10 19:03:10 2020 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>Fri Jul 10 19:03:10 2020 +0000
treec23cde41453e9697481fe3452b8d791da9bfba38
parent3bf1babaa60ffd0f180f35d287db642f74388353 [diff]
parenteb3132ef434998eb10c06551c5f60e57402bea58 [diff]
[automerger skipped] Handle case where checkstyle does not return 2 lines. am: e1510db8d1 am: dc1108fcd0 -s ours am: 9c3a99aa41 -s ours am: eb3132ef43 -s ours

am skip reason: Change-Id Ia27b93eafd7471f3886e4d3a4080a63dc5e8e935 with SHA-1 222ffec85d is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/prebuilts/checkstyle/+/12129281

Change-Id: I8d39ae66752d652737d0efc36e22f3b053ace20c
tree: c23cde41453e9697481fe3452b8d791da9bfba38
  1. gitlint/
  2. .gitignore
  3. android-style.xml
  4. checkstyle.jar
  5. checkstyle.py
  6. default-copyright-check.xml
  7. default-javadoc-checks.xml
  8. default-module-checks.xml
  9. default-treewalker-checks.xml
  10. LICENSE
  11. OWNERS
  12. PREUPLOAD.cfg
  13. README.md
  14. tests.py
README.md

Checkstyle

Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.

Running it

It can be invoked in two ways.

  1. To check style of entire specific files: checkstyle.py -f FILE [FILE ...]
  2. To check style of the lines modified in the latest commit: checkstyle.py

Projects used

Checkstyle

A development tool to help programmers write Java code that adheres to a coding standard.

Git-Lint

Git-lint is a tool to run lint checks on only files changed in the latest commit.

  • URL: https://github.com/sk-/git-lint/
  • Version: 0.0.8
  • License: Apache 2.0
  • License File: gitlint/LICENSE
  • Local Modifications:
    • Downloaded gitlint/git.py and git/utils.py files individually.

Pre-upload linting

To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg:

checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}

Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.

Disabling Clang Format for Java

In .clang-format add the following to disable format checking and correcting for Java:

---
Language: Java
DisableFormat: true
SortIncludes: false
---

In some versions of clang-format, DisableFormat doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.