commit | dc1108fcd0d9eef7e42f34546b7ae2f88e8d2475 | [log] [tgz] |
---|---|---|
author | Sam Saccone <samccone@google.com> | Fri Jul 10 18:23:58 2020 +0000 |
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | Fri Jul 10 18:23:58 2020 +0000 |
tree | 242c695e254ef9393678010544bf7cdfb32d0381 | |
parent | 43f6c66939093b8f1b7d36b1279bd689810b7989 [diff] | |
parent | e1510db8d13df2c2f3dd923a4a09c20b6b531d92 [diff] |
Handle case where checkstyle does not return 2 lines. am: e1510db8d1 Original change: https://googleplex-android-review.googlesource.com/c/platform/prebuilts/checkstyle/+/12129281 Change-Id: I594668e90f24bde6cb5cc344e2dac18430c427fb
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.