commit | 66df0cc063e3b71c6bc79b824e0a79bca649e58f | [log] [tgz] |
---|---|---|
author | Sam Saccone <samccone@google.com> | Fri Jul 10 18:23:59 2020 +0000 |
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | Fri Jul 10 18:23:59 2020 +0000 |
tree | c23cde41453e9697481fe3452b8d791da9bfba38 | |
parent | 3d542f409cf27ab0d8c16170a0ce1f364659bdb0 [diff] | |
parent | e1510db8d13df2c2f3dd923a4a09c20b6b531d92 [diff] |
[automerger skipped] Handle case where checkstyle does not return 2 lines. am: e1510db8d1 -s ours am skip reason: Change-Id Ia27b93eafd7471f3886e4d3a4080a63dc5e8e935 with SHA-1 222ffec85d is in history Original change: https://googleplex-android-review.googlesource.com/c/platform/prebuilts/checkstyle/+/12129281 Change-Id: I38cea7f18e487010030f99362d196e3e24b7b37c
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.