Clone this repo:
  1. 5f0758d Add cts hostside tests path to known test paths am: 167a960592 by Nandana Dutt · 7 weeks ago androidx-main-release master
  2. 167a960 Add cts hostside tests path to known test paths by Nandana Dutt · 8 weeks ago
  3. 44d22df Mark ab/6881855 as merged by Xin Li · 9 weeks ago
  4. bc96dc0 Skip ab/6749736 in stage. by Xin Li · 4 months ago androidx-print-release androidx-wear-wear-input-release
  5. 845415d [automerger skipped] Merge Android R am: 9a3581ccec -s ours am: a0c8263eee -s ours am: 67113da08b -s ours am: 7f87ef5555 -s ours by Xin Li · 4 months ago

Checkstyle

Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.

Running it

It can be invoked in two ways.

  1. To check style of entire specific files: checkstyle.py -f FILE [FILE ...]
  2. To check style of the lines modified in the latest commit: checkstyle.py

Projects used

Checkstyle

A development tool to help programmers write Java code that adheres to a coding standard.

Git-Lint

Git-lint is a tool to run lint checks on only files changed in the latest commit.

  • URL: https://github.com/sk-/git-lint/
  • Version: 0.0.8
  • License: Apache 2.0
  • License File: gitlint/LICENSE
  • Local Modifications:
    • Downloaded gitlint/git.py and git/utils.py files individually.

Pre-upload linting

To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg:

checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}

Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.

Disabling Clang Format for Java

In .clang-format add the following to disable format checking and correcting for Java:

---
Language: Java
DisableFormat: true
SortIncludes: false
---

In some versions of clang-format, DisableFormat doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.