d65f234e8 - platform/platform_testing

commit	d65f234e84eee30a8abc0869b7c5231ca6b799f2	[log] [tgz]
author	Nataniel Borges <natanieljr@google.com>	Tue Dec 14 11:26:37 2021 +0100
committer	Nataniel Borges <natanieljr@google.com>	Tue Dec 14 11:26:37 2021 +0100
tree	e49b671990abda7e440aea63393d5fc449e555ed
parent	5acd03303498873c159bd9d3303e8089c311e6b7 [diff]

Better support for empty traces/states

At the moment many methods in flicker assume the trace (or state) will never be empty and invoke "first()" or "last()" without checks. This may result in hard to decipher error messages that don't point correctly to the issue.

Moreover, some of these calls occur on the "toString()" subject methods, causing debugging issues.

Instead use "firstOrNull()" and "lastOrNull()" to provide proper error messages for cases when traces or states are empty

Bug: 210465715
Test: atest FlickerLibTest
Change-Id: I0b24601a5626d86d7654a3b2c27a66048c8b6757

libraries/flicker/src/com/android/server/wm/flicker/service/assertors/common/RotationLayerAppearsAndVanishes.kt[diff]
libraries/flicker/src/com/android/server/wm/flicker/service/assertors/common/StatusBarLayerPositionAtEnd.kt[diff]
libraries/flicker/src/com/android/server/wm/flicker/service/assertors/common/StatusBarLayerPositionAtStart.kt[diff]
libraries/flicker/src/com/android/server/wm/flicker/traces/FlickerTraceSubject.kt[diff]
libraries/flicker/src/com/android/server/wm/flicker/traces/eventlog/EventLogSubject.kt[diff]
libraries/flicker/src/com/android/server/wm/flicker/traces/layers/LayersTraceSubject.kt[diff]
libraries/flicker/src/com/android/server/wm/traces/common/errors/ErrorTrace.kt[diff]
libraries/flicker/src/com/android/server/wm/traces/common/layers/LayersTrace.kt[diff]
libraries/flicker/src/com/android/server/wm/traces/common/windowmanager/WindowManagerTrace.kt[diff]

9 files changed

tree: e49b671990abda7e440aea63393d5fc449e555ed

build/
docs/
emu_test/
libraries/
scripts/
tests/
utils/
PREUPLOAD.cfg