tree b85c32b362cee0438684467400356812cad096ce
parent 7288dee1251da3d5fabba7104ce6b0fe498e2b30
author Tyler Gunn <tgunn@google.com> 1562878208 -0700
committer android-build-team Robot <android-build-team-robot@google.com> 1563213113 +0000

Fix call redirection service issues.

1.
Pressing the "home" button or otherwise switching apps while the call
redirection dialog is showing puts the device in a bad state.  The dialog
can no longer be visited from the recents menu, and as such you end up
with a call stuck in a connecting state.  This prevents all future calls
from being placed until reboot.

To fix this, add an onStop handler which will ensure that redirection is
canceled if the user switches apps or hits the home button.

Also, fixed an invalid string which was causing a string formatting error
(too many %s'es).

2. Fix issue where emergency numbers were being routed to a call
redirection service.  These should NOT be.

Test: Place call with redirection app installed; cancel from dialog and
verify it cancels call.
Test: Place call with redirection app installed; place call using carrier
from dialog and verify it connects call via carrier.
Test: Place call with redirection app installed; place call using redir
app from dialog and verify it connects call via redirection app.
Test: Hit home to dismiss the dialog; verify call is canceled.
Test: Add test emergency number, verify can call emergency number
Fixes: 137223601
Fixes: 137315607
Change-Id: I7274bf5c34d5f119e011e6828b97ed2fe270c303
(cherry picked from commit bb5866f2e851719239ac568e86bdcb6655cc2dd8)