tree 9f9794e70ab329c6af668bd450e63e5b4b1a6b61
parent ece56fc6cefd8102a0718375e03831d52a24c4f6
author Svet Ganov <svetoslavganov@google.com> 1569561173 -0700
committer Philip P. Moltmann <moltmann@google.com> 1571073508 +0000

[DO NOT MERGE] Update PermissionChecker usages to avoid unnecessary attribution.

We had accidental usages of the PermissionChecker for cases where no
private data was provided to the app but the checkPermission API on
the latter also did blame data access on the app. The PermissionChecker
was designed to handle IPC calls and not for generic API checks.

To avoid future accidental incorrect PermissionChecker usages this
change renames the existing APIs of the latter to clearly indicate
that they should be used for data delivery and also adds sibling
methods for doing the same permission checks for preflight purposes.
Also the documentation is improved to furhter assist developers.

In addition, this change fixes accidental permission checker usages
that blame when they should not by using the new preflight flavor
of the permission check APIs.

Test:
    atest com.android.settingslib.location.RecentLocationAppsTest
    atest CtsPermissionTestCases
    added: LocationAccessCheckTest#notificationOnlyForAccessesSinceFeatureWasEnabled
    added: LocationAccessCheckTest#noNotificationIfFeatureDisabled
    added: LocationAccessCheckTest#noNotificationIfBlamerNotSystemOrLocationProvider
    added: LocationAccessCheckTest#testOpeningLocationSettingsDoesNotTriggerAccess

bug:141028068
Change-Id: I8f9f897e486b53d681d0793045b8602df253cd23
Merged-In: I70f94c1693bbddc47371302388ebf3bea1c988fd
Merged-In: I24e7f16f70ab183a9515e6e298d21ccb9006c3cf
Merged-In: I24c0ee2a8e6826ea81fe46c14bafb3d051bd4e45