tree b35e8ee0584685e05c2236ff7756c115618ee61d
parent a3452c2cd0935f30c231b857a02fa4ea53120472
author Jeff Sharkey <jsharkey@android.com> 1563411289 -0600
committer android-build-team Robot <android-build-team-robot@google.com> 1568945868 +0000

RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change starts using setStrictColumns() and setStrictGrammar()
on SQLiteQueryBuilder to block this class of attacks.  This means we
now need to define the projection mapping of valid columns, which
consists of both the columns defined in the public API and columns
read internally by DownloadInfo.Reader.

We're okay growing sAppReadableColumnsSet like this, since we're
relying on our trusted WHERE clause to filter away any rows that
don't belong to the calling UID.

Remove the legacy Lexer code, since we're now internally relying on
the robust and well-tested SQLiteTokenizer logic.

Bug: 135270103, 135269143
Test: atest DownloadProviderTests
Test: atest CtsAppTestCases:android.app.cts.DownloadManagerTest
Change-Id: I8e595e1470df586a3d593b7851305da413e44347
(cherry picked from commit ffec00b013a34800681ec90c88ad40337aa20c1a)