commit d3b51e172bba03af7d2fcc3559cfa73b6ce60095
author Alon Albert <aalbert@google.com> Mon Oct 28 09:48:54 2013 -0700
committer Alon Albert <aalbert@google.com> Mon Oct 28 09:48:54 2013 -0700
tree 28b8583624dd3c86cf5e763dabed5d8c41476fb5
parent 718f083598885f56e49d1846dab0f37607ef33d7

Handle Missing Event Row

When checking for Calendars.CAN_PARTIALLY_UPDATE in duplicateEvent() , don't
crash if there is no matching event id in the db.

Bug: 11392862
Change-Id: I895c3a307b842c4340c851da27c25951d3e7968f

src/com/android/providers/calendar/CalendarDatabaseHelper.java

diff --git a/src/com/android/providers/calendar/CalendarDatabaseHelper.java b/src/com/android/providers/calendar/CalendarDatabaseHelper.java
index dc3deba..407e21a 100644
--- a/src/com/android/providers/calendar/CalendarDatabaseHelper.java
+++ b/src/com/android/providers/calendar/CalendarDatabaseHelper.java
@@ -24,6 +24,7 @@
 import android.database.DatabaseUtils;
 import android.database.SQLException;
 import android.database.sqlite.SQLiteDatabase;
+import android.database.sqlite.SQLiteDoneException;
 import android.database.sqlite.SQLiteException;
 import android.database.sqlite.SQLiteOpenHelper;
 import android.os.Bundle;
@@ -3367,12 +3368,21 @@
      */
     protected void duplicateEvent(final long id) {
         final SQLiteDatabase db = getWritableDatabase();
-        final long canPartiallyUpdate = DatabaseUtils.longForQuery(db, "SELECT "
-                + Calendars.CAN_PARTIALLY_UPDATE + " FROM " + Views.EVENTS
-                + " WHERE " + Events._ID + " = ?", new String[] {
-            String.valueOf(id)
-        });
-        if (canPartiallyUpdate == 0) {
+        try {
+            final long canPartiallyUpdate = DatabaseUtils.longForQuery(db, "SELECT "
+                    + Calendars.CAN_PARTIALLY_UPDATE + " FROM " + Views.EVENTS
+                    + " WHERE " + Events._ID + " = ?", new String[] {
+                String.valueOf(id)
+            });
+            if (canPartiallyUpdate == 0) {
+                return;
+            }
+        } catch (SQLiteDoneException e) {
+            // b/11392862
+            // If no results are returned, this will be thrown. This can happen if the Events View
+            // has no rows for the provided id. This might happen for example if someone inserts a
+            // reminder that refers to a non existent event id.
+            // Return without doing anything because there is no event to duplicate.
             return;
         }