Google GitGoogle Git
Sign in
android/platform/packages/modules/adb/fdbd8a5f
commit
fdbd8a5f26c58722ddf414afc591fcdbca5389d4
[log]
author
Joshua Duong <joshuaduong@google.com>
Sun Apr 19 16:11:06 2026 +0000
committer
Android Build Coastguard Worker <android-build-coastguard-worker@google.com>
Thu Jul 09 19:08:17 2026 -0700
tree
7d3eebcce40603970ef5cfead1a0d02ebbd37c0b
parent
9084198a2d4b0f6a0f174260fb42da33485b684d [diff]
[adb] Document and harden async transport flow.

Add detailed documentation to the global 'transports' map and its
associated helper functions in adbd auth. These helpers are used to
safely pass 'atransport' objects across asynchronous boundaries (like
user authorization popups or background TLS handshakes) without risking
Use-After-Free.

Also add CHECK_LOOPER_THREAD() assertions to ensure these functions are
only called on the main fdevent thread, which is a requirement for the
thread-safety of the global map and the underlying weak_ptr.

Finally, refactor transport_from_callback_arg to use std::map::extract,
which simplifies the code and ensures the entry is always removed from
the map upon retrieval.

Bug: 499053500
Test: atest adb_test --host
Flag: EXEMPT BUGFIX
Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:ca8689b1047a05598bb42ff034652ea679dd6056
Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:ea885606faf989081914b3aa699d42d0a46abb28
Merged-In: Ic419a1fb6f0df1ff868a1a31a33ded8a0ae7b2e8
Change-Id: Ic419a1fb6f0df1ff868a1a31a33ded8a0ae7b2e8
1 file changed
tree: 7d3eebcce40603970ef5cfead1a0d02ebbd37c0b
  1. apex/
  2. client/
  3. coverage/
  4. crypto/
  5. daemon/
  6. docs/
  7. fastdeploy/
  8. fdevent/
  9. libs/
  10. pairing_auth/
  11. pairing_connection/
  12. proto/
  13. sysdeps/
  14. test_device_apks/
  15. test_utils/
  16. tls/
  17. tools/
  18. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  19. .clang-format
  20. adb.bash
  21. adb.cpp
  22. adb.h
  23. adb_auth.h
  24. adb_integration_test_adb.xml
  25. adb_integration_test_device.xml
  26. adb_io.cpp
  27. adb_io.h
  28. adb_io_test.cpp
  29. adb_listeners.cpp
  30. adb_listeners.h
  31. adb_listeners_test.cpp
  32. adb_mdns.cpp
  33. adb_mdns.h
  34. adb_trace.cpp
  35. adb_trace.h
  36. adb_unique_fd.cpp
  37. adb_unique_fd.h
  38. adb_utils.cpp
  39. adb_utils.h
  40. adb_utils_test.cpp
  41. adbd_flags.aconfig
  42. adbd_test.map
  43. adbd_test.xml
  44. Android.bp
  45. apacket_reader.cpp
  46. apacket_reader.h
  47. benchmark_device.py
  48. bugreport_test.cpp
  49. compression_utils.h
  50. file_sync_protocol.h
  51. mdns_test.cpp
  52. MODULE_LICENSE_APACHE2
  53. NOTICE
  54. OWNERS
  55. PREUPLOAD.cfg
  56. README.md
  57. run-device-tests.sh
  58. security_log_tags.h
  59. services.cpp
  60. services.h
  61. shell_protocol.h
  62. shell_service_protocol.cpp
  63. shell_service_protocol_test.cpp
  64. socket.h
  65. socket_spec.cpp
  66. socket_spec.h
  67. socket_spec_test.cpp
  68. socket_test.cpp
  69. sockets.cpp
  70. sockets.dia
  71. sysdeps.h
  72. sysdeps_test.cpp
  73. sysdeps_unix.cpp
  74. sysdeps_win32.cpp
  75. sysdeps_win32_test.cpp
  76. test_adb.py
  77. test_device.py
  78. TEST_MAPPING
  79. trace.sh
  80. transfer_id.h
  81. transport.cpp
  82. transport.h
  83. transport_benchmark.cpp
  84. transport_fd.cpp
  85. transport_test.cpp
  86. types.cpp
  87. types.h
  88. types_test.cpp
README.md

ADB (Android Debug Bridge) repository

The Android Debug Bridge connects Android devices to computers running other OSes (Linux, MacOS, and Windows) over USB or TCP.

User documentation

Developer documentation

main page