commit 3bccdf76fcd631005f343641388befcc6eef525e
author Jay Thomas Sullivan <jaysullivan@google.com> Mon Mar 13 16:40:12 2023 -0700
committer Jay Sullivan <jaysullivan@google.com> Tue Mar 14 23:09:17 2023 +0000
tree 24a33d5b7f42a0bab693f77318120763bc6a4a83
parent 4d3b50f2ff3a93c5fbfb204c190a1d22e7740a5c

[Safety Labels] Replace right/left with start/end

In this view, we have a few references to "right" and "left", which
resulted in an undesirable layout for RTL languages. Use "start" and
"end", instead, so that everything mirrors, including which side of our
elements we place padding.

Also, add textDirection="locale" and layoutDirection="locale" to the
root element. A vendor found that the text direction was incorrect for
an RTL language. This was unreproducable by us, so admittedly this
solution is somewhat of a guess (though it is recommmended as i18n best
practice, so shouldn't cause any harm).

Bug: 271422001
Test: atest CtsPermission3TestCases:android.permission3.cts.SafetyLabelChangesJobServiceTest
Change-Id: I30947281002545d8b9b209914e92a60f84661c96

PermissionController/res/values-v34/styles.xml

diff --git a/PermissionController/res/values-v34/styles.xml b/PermissionController/res/values-v34/styles.xml
index 4b413f9..82ba7ed 100644
--- a/PermissionController/res/values-v34/styles.xml
+++ b/PermissionController/res/values-v34/styles.xml
@@ -173,6 +173,8 @@
         <item name="android:layout_marginEnd">24dp</item>
         <item name="android:orientation">vertical</item>
         <item name="android:clipToPadding">false</item>
+        <item name="android:textDirection">locale</item>
+        <item name="android:layoutDirection">locale</item>
     </style>
 
     <style name="AppDataSharingDetailsTextAppearance"
@@ -212,6 +214,8 @@
         <item name="android:layout_marginEnd">24dp</item>
         <item name="android:orientation">vertical</item>
         <item name="android:clipToPadding">false</item>
+        <item name="android:textDirection">locale</item>
+        <item name="android:layoutDirection">locale</item>
     </style>
 
     <style name="AppDataSharingUpdatesFooterIconFrame">
@@ -262,12 +266,14 @@
         <item name="android:paddingStart">24dp</item>
         <item name="android:paddingEnd">24dp</item>
         <item name="android:clipToPadding">false</item>
+        <item name="android:textDirection">locale</item>
+        <item name="android:layoutDirection">locale</item>
     </style>
 
     <style name="AppDataSharingUpdateAppIconFrame">
         <item name="android:layout_width">wrap_content</item>
         <item name="android:layout_height">match_parent</item>
-        <item name="android:paddingRight">20dp</item>
+        <item name="android:paddingEnd">20dp</item>
     </style>
 
     <style name="AppDataSharingUpdateAppIcon">
@@ -304,9 +310,9 @@
     <style name="AppDataSharingUpdateSettingsIconFrame">
         <item name="android:layout_width">48dp</item>
         <item name="android:layout_height">match_parent</item>
-        <item name="android:gravity">right|center_vertical</item>
+        <item name="android:gravity">end|center_vertical</item>
         <item name="android:orientation">vertical</item>
-        <item name="android:paddingLeft">24dp</item>
+        <item name="android:paddingStart">24dp</item>
     </style>
 
     <style name="AppDataSharingUpdateSettingsIcon">