commit 374b596b6c4fb0e2bbf7e4666f725433e179037b
author Nate Myren <ntmyren@google.com> Tue Mar 04 13:21:27 2025 -0800
committer Nate Myren <ntmyren@google.com> Wed Mar 05 09:27:05 2025 -0800
tree d134020e7705d0beea0afc3cbe1bf137910cc9f5
parent 8595dc01e81d1d2c4a3357c58e27710330aa994f

Add cooldown to ECM logging

Bug: 364535720
Test: manual
Flag: android.permission.flags.unknown_call_setting_blocked_logging_enabled
Relnote: none
LOW_COVERAGE_REASON=FLAG_NOT_ENABLED

Change-Id: If3c8fd6867d73b452b49fc8fb61fe0ee0eb0b951

service/java/com/android/ecm/EnhancedConfirmationService.java

diff --git a/service/java/com/android/ecm/EnhancedConfirmationService.java b/service/java/com/android/ecm/EnhancedConfirmationService.java
index 0566a82..e06d97d 100644
--- a/service/java/com/android/ecm/EnhancedConfirmationService.java
+++ b/service/java/com/android/ecm/EnhancedConfirmationService.java
@@ -150,8 +150,6 @@
 
     private Map<String, List<byte[]>> mTrustedPackageCertDigests;
     private Map<String, List<byte[]>> mTrustedInstallerCertDigests;
-
-    private static final long UNTRUSTED_CALL_STORAGE_TIME_MS = TimeUnit.HOURS.toMillis(1);
     private static final int CALL_TYPE_UNTRUSTED = 0;
     private static final int CALL_TYPE_TRUSTED = 1;
     private static final int CALL_TYPE_EMERGENCY = 1 << 1;
@@ -559,10 +557,19 @@
     }
 
     private static class CallTracker {
+        // The time we will remember an untrusted call
+        private static final long UNTRUSTED_CALL_STORAGE_TIME_MS = TimeUnit.HOURS.toMillis(1);
+        // The minimum time that must pass between individual logs of the same call, uid, trusted
+        // status, and allowed setting.
+        private static final long MAX_LOGGING_FREQUENCY_MS = TimeUnit.SECONDS.toMillis(30);
         // A map of call ID to ongoing or recently removed calls. Concurrent because
         // additions/removals happen on background threads, but queries on main thread.
         private final Map<String, TrackedCall> mCalls = new ConcurrentHashMap<>();
 
+        // A cache of hashed callers, uids, trusted status, and allowed status. Ensures that we
+        // do not log the same interaction too many times
+        private final Map<Integer, Long> mLogCache = new ConcurrentHashMap<>();
+
         private class TrackedCall {
             public @CallType Integer callType;
             public String caller;
@@ -606,6 +613,7 @@
                 return;
             }
             pruneOldFinishedCalls();
+            pruneOldLogs();
             mCalls.put(call.getDetails().getId(), new TrackedCall(call));
         }
 
@@ -638,6 +646,7 @@
             }
 
             pruneOldFinishedCalls();
+            pruneOldLogs();
         }
 
         public void endAllCalls() {
@@ -772,6 +781,15 @@
             mCalls.entrySet().removeIf(
                     e -> e.getValue().isFinished() && e.getValue().endTime < cutoff);
         }
+
+        void pruneOldLogs() {
+            if (!Flags.unknownCallSettingBlockedLoggingEnabled()) {
+                return;
+            }
+            long cutoff = SystemClock.elapsedRealtime() - MAX_LOGGING_FREQUENCY_MS;
+            mLogCache.entrySet().removeIf(e -> e.getValue() < cutoff);
+        }
+
         private void logInCallRestrictionEvent(@NonNull String packageName, int userId,
                 @NonNull String settingIdentifier, boolean allowed, @Nullable TrackedCall call) {
             if (!Flags.unknownCallSettingBlockedLoggingEnabled()) {
@@ -812,6 +830,15 @@
                 }
             }
 
+            String caller = callInProgress ? call.caller : null;
+            int logHash = Objects.hash(caller, uid, settingIdentifier, allowed, trusted);
+            Long lastLogTime = mLogCache.get(logHash);
+            long cutoff = SystemClock.elapsedRealtime() - MAX_LOGGING_FREQUENCY_MS;
+            if (lastLogTime != null && lastLogTime > cutoff) {
+                return;
+            }
+            mLogCache.put(logHash, SystemClock.elapsedRealtime());
+
             PermissionControllerStatsLog.write(ECM_RESTRICTION_QUERY_IN_CALL_REPORTED, uid,
                     settingIdentifier, allowed, callInProgress, incoming, trusted,
                     callBackAfterBlock);