Snap for 8298627 from 7d5a5666ef448a4811515626301bfc0ecba288b5 to mainline-adbd-release Change-Id: I1e6b7b9eb6d3c9417fe1875e5a4de90d350502e2
diff --git a/Android.bp b/Android.bp index 891d34b..d11bf8a 100644 --- a/Android.bp +++ b/Android.bp
@@ -172,7 +172,7 @@ "NetworkStackApi31Shims", "framework-bluetooth", "framework-connectivity", - "framework-connectivity-tiramisu.stubs.module_lib", + "framework-connectivity-t.stubs.module_lib", "framework-tethering", ], sdk_version: "module_current",
diff --git a/apishim/29/com/android/networkstack/apishim/api29/ConstantsShim.java b/apishim/29/com/android/networkstack/apishim/api29/ConstantsShim.java index 0b000a9..a6ca1f1 100644 --- a/apishim/29/com/android/networkstack/apishim/api29/ConstantsShim.java +++ b/apishim/29/com/android/networkstack/apishim/api29/ConstantsShim.java
@@ -42,4 +42,6 @@ // Constants defined in android.net.NetworkCapabilities. public static final int NET_CAPABILITY_NOT_VCN_MANAGED = 28; + // Constants defined in android.content.Context + public static final String NEARBY_SERVICE = "nearby"; }
diff --git a/apishim/29/com/android/networkstack/apishim/api29/Ikev2VpnProfileShimImpl.java b/apishim/29/com/android/networkstack/apishim/api29/Ikev2VpnProfileShimImpl.java index d9ad4fe..b3f5f43 100644 --- a/apishim/29/com/android/networkstack/apishim/api29/Ikev2VpnProfileShimImpl.java +++ b/apishim/29/com/android/networkstack/apishim/api29/Ikev2VpnProfileShimImpl.java
@@ -25,10 +25,10 @@ */ public class Ikev2VpnProfileShimImpl<T> implements Ikev2VpnProfileShim<T> { /** - * @see Ikev2VpnProfile#getRequiresInternetValidation(boolean) + * @see Ikev2VpnProfile#isInternetValidationRequired(boolean) */ @Override - public boolean getRequiresInternetValidation(T profile) + public boolean isInternetValidationRequired(T profile) throws UnsupportedApiLevelException { throw new UnsupportedApiLevelException("Only supported from API level 33."); }
diff --git a/apishim/29/com/android/networkstack/apishim/api29/NetworkAgentConfigShimImpl.java b/apishim/29/com/android/networkstack/apishim/api29/NetworkAgentConfigShimImpl.java index 3c38b87..c2260dc 100644 --- a/apishim/29/com/android/networkstack/apishim/api29/NetworkAgentConfigShimImpl.java +++ b/apishim/29/com/android/networkstack/apishim/api29/NetworkAgentConfigShimImpl.java
@@ -23,7 +23,7 @@ */ public class NetworkAgentConfigShimImpl implements NetworkAgentConfigShim { @Override - public boolean getVpnRequiresValidation() { + public boolean isVpnValidationRequired() { return false; } }
diff --git a/apishim/33/com/android/networkstack/apishim/Ikev2VpnProfileShimImpl.java b/apishim/33/com/android/networkstack/apishim/Ikev2VpnProfileShimImpl.java index 6267eee..ccaf497 100644 --- a/apishim/33/com/android/networkstack/apishim/Ikev2VpnProfileShimImpl.java +++ b/apishim/33/com/android/networkstack/apishim/Ikev2VpnProfileShimImpl.java
@@ -44,10 +44,10 @@ } /** - * @see Ikev2VpnProfile#getRequiresInternetValidation() + * @see Ikev2VpnProfile#isInternetValidationRequired() */ @Override - public boolean getRequiresInternetValidation(@NonNull final Ikev2VpnProfile profile) { - return profile.getRequiresInternetValidation(); + public boolean isInternetValidationRequired(@NonNull final Ikev2VpnProfile profile) { + return profile.isInternetValidationRequired(); } }
diff --git a/apishim/33/com/android/networkstack/apishim/NetworkAgentConfigShimImpl.java b/apishim/33/com/android/networkstack/apishim/NetworkAgentConfigShimImpl.java index 5e78fda..912b721 100644 --- a/apishim/33/com/android/networkstack/apishim/NetworkAgentConfigShimImpl.java +++ b/apishim/33/com/android/networkstack/apishim/NetworkAgentConfigShimImpl.java
@@ -46,11 +46,11 @@ } @Override - public boolean getVpnRequiresValidation() { + public boolean isVpnValidationRequired() { if (null == mNetworkAgentConfig) { return false; } else { - return mNetworkAgentConfig.getVpnRequiresValidation(); + return mNetworkAgentConfig.isVpnValidationRequired(); } }
diff --git a/apishim/common/com/android/networkstack/apishim/common/Ikev2VpnProfileShim.java b/apishim/common/com/android/networkstack/apishim/common/Ikev2VpnProfileShim.java index 1c42330..4a79c43 100644 --- a/apishim/common/com/android/networkstack/apishim/common/Ikev2VpnProfileShim.java +++ b/apishim/common/com/android/networkstack/apishim/common/Ikev2VpnProfileShim.java
@@ -26,7 +26,7 @@ // TODO : when API29 is no longer supported, remove the type argument public interface Ikev2VpnProfileShim<T> { /** - * @see Ikev2VpnProfile#getRequiresInternetValidation() + * @see Ikev2VpnProfile#isInternetValidationRequired() */ - boolean getRequiresInternetValidation(T profile) throws UnsupportedApiLevelException; + boolean isInternetValidationRequired(T profile) throws UnsupportedApiLevelException; }
diff --git a/apishim/common/com/android/networkstack/apishim/common/NetworkAgentConfigShim.java b/apishim/common/com/android/networkstack/apishim/common/NetworkAgentConfigShim.java index 6274aa4..fb0e545 100644 --- a/apishim/common/com/android/networkstack/apishim/common/NetworkAgentConfigShim.java +++ b/apishim/common/com/android/networkstack/apishim/common/NetworkAgentConfigShim.java
@@ -23,7 +23,7 @@ */ public interface NetworkAgentConfigShim { /** - * @see NetworkAgentConfig#getVpnRequiresValidation() + * @see NetworkAgentConfig#isVpnValidationRequired() */ - boolean getVpnRequiresValidation(); + boolean isVpnValidationRequired(); }
diff --git a/common/moduleutils/Android.bp b/common/moduleutils/Android.bp index f87bcdd..c0ee3f4 100644 --- a/common/moduleutils/Android.bp +++ b/common/moduleutils/Android.bp
@@ -26,7 +26,6 @@ name: "net-module-utils-srcs", srcs: [ "src/android/net/shared/NetdUtils.java", - "src/android/net/util/InterfaceParams.java", "src/android/net/util/SharedLog.java", ], visibility: [ @@ -40,7 +39,6 @@ "src/android/net/util/SharedLog.java", "src/android/net/shared/NetdUtils.java", "src/android/net/shared/NetworkMonitorUtils.java", - "src/android/net/util/InterfaceParams.java", ], visibility: [ "//packages/modules/Connectivity/service", @@ -64,7 +62,6 @@ "src/android/net/ip/IpNeighborMonitor.java", "src/android/net/ip/NetlinkMonitor.java", "src/android/net/shared/NetdUtils.java", - "src/android/net/util/InterfaceParams.java", "src/android/net/util/SharedLog.java", ], visibility: [
diff --git a/common/moduleutils/src/android/net/util/InterfaceParams.java b/common/moduleutils/src/android/net/util/InterfaceParams.java deleted file mode 100644 index 0982981..0000000 --- a/common/moduleutils/src/android/net/util/InterfaceParams.java +++ /dev/null
@@ -1,101 +0,0 @@ -/* - * Copyright (C) 2019 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package android.net.util; - -import android.net.MacAddress; -import android.text.TextUtils; - -import java.net.NetworkInterface; -import java.net.SocketException; - - -/** - * Encapsulate the interface parameters common to IpClient/IpServer components. - * - * Basically all java.net.NetworkInterface methods throw Exceptions. IpClient - * and IpServer (sub)components need most or all of this information at some - * point during their lifecycles, so pass only this simplified object around - * which can be created once when IpClient/IpServer are told to start. - * - * @hide - */ -public class InterfaceParams { - public final String name; - public final int index; - public final boolean hasMacAddress; - public final MacAddress macAddr; - public final int defaultMtu; - - // TODO: move the below to NetworkStackConstants when this class is moved to the NetworkStack. - private static final int ETHER_MTU = 1500; - private static final int IPV6_MIN_MTU = 1280; - - - public static InterfaceParams getByName(String name) { - final NetworkInterface netif = getNetworkInterfaceByName(name); - if (netif == null) return null; - - // Not all interfaces have MAC addresses, e.g. rmnet_data0. - final MacAddress macAddr = getMacAddress(netif); - - try { - return new InterfaceParams(name, netif.getIndex(), macAddr, netif.getMTU()); - } catch (IllegalArgumentException|SocketException e) { - return null; - } - } - - public InterfaceParams(String name, int index, MacAddress macAddr) { - this(name, index, macAddr, ETHER_MTU); - } - - public InterfaceParams(String name, int index, MacAddress macAddr, int defaultMtu) { - if (TextUtils.isEmpty(name)) { - throw new IllegalArgumentException("impossible interface name"); - } - - if (index <= 0) throw new IllegalArgumentException("invalid interface index"); - - this.name = name; - this.index = index; - this.hasMacAddress = (macAddr != null); - this.macAddr = hasMacAddress ? macAddr : MacAddress.fromBytes(new byte[] { - 0x02, 0x00, 0x00, 0x00, 0x00, 0x00 }); - this.defaultMtu = (defaultMtu > IPV6_MIN_MTU) ? defaultMtu : IPV6_MIN_MTU; - } - - @Override - public String toString() { - return String.format("%s/%d/%s/%d", name, index, macAddr, defaultMtu); - } - - private static NetworkInterface getNetworkInterfaceByName(String name) { - try { - return NetworkInterface.getByName(name); - } catch (NullPointerException|SocketException e) { - return null; - } - } - - private static MacAddress getMacAddress(NetworkInterface netif) { - try { - return MacAddress.fromBytes(netif.getHardwareAddress()); - } catch (IllegalArgumentException|NullPointerException|SocketException e) { - return null; - } - } -}
diff --git a/common/networkstackclient/Android.bp b/common/networkstackclient/Android.bp index 1fbf525..6e44450 100644 --- a/common/networkstackclient/Android.bp +++ b/common/networkstackclient/Android.bp
@@ -193,6 +193,7 @@ ], static_libs: [ "networkstack-aidl-latest", + "modules-utils-build", ], visibility: [ "//frameworks/base/packages/Connectivity/service",
diff --git a/common/networkstackclient/src/android/net/NetworkMonitorManager.java b/common/networkstackclient/src/android/net/NetworkMonitorManager.java index 2cfec17..98598a1 100644 --- a/common/networkstackclient/src/android/net/NetworkMonitorManager.java +++ b/common/networkstackclient/src/android/net/NetworkMonitorManager.java
@@ -23,6 +23,8 @@ import android.os.RemoteException; import android.util.Log; +import com.android.modules.utils.build.SdkLevel; + /** * A convenience wrapper for INetworkMonitor. * @@ -151,7 +153,12 @@ public boolean notifyNetworkConnected(NetworkMonitorParameters params) { final long token = Binder.clearCallingIdentity(); try { - mNetworkMonitor.notifyNetworkConnectedParcel(params); + if (SdkLevel.isAtLeastT()) { + mNetworkMonitor.notifyNetworkConnectedParcel(params); + } else { + mNetworkMonitor.notifyNetworkConnected(params.linkProperties, + params.networkCapabilities); + } return true; } catch (RemoteException e) { log("Error in notifyNetworkConnected", e);
diff --git a/common/networkstackclient/src/android/net/networkstack/ModuleNetworkStackClient.java b/common/networkstackclient/src/android/net/networkstack/ModuleNetworkStackClient.java index cbbae37..c3079fe 100644 --- a/common/networkstackclient/src/android/net/networkstack/ModuleNetworkStackClient.java +++ b/common/networkstackclient/src/android/net/networkstack/ModuleNetworkStackClient.java
@@ -44,9 +44,7 @@ */ @NonNull public static synchronized ModuleNetworkStackClient getInstance(Context packageContext) { - // TODO(b/149676685): change this check to "< R" once R is defined - if (SDK_INT < Build.VERSION_CODES.Q - || (SDK_INT == Build.VERSION_CODES.Q && "REL".equals(Build.VERSION.CODENAME))) { + if (SDK_INT < Build.VERSION_CODES.R) { // The NetworkStack connector is not available through NetworkStack before R throw new UnsupportedOperationException( "ModuleNetworkStackClient is not supported on API " + SDK_INT);
diff --git a/res/values-da/strings.xml b/res/values-da/strings.xml index 706f174..e54f11c 100644 --- a/res/values-da/strings.xml +++ b/res/values-da/strings.xml
@@ -19,7 +19,7 @@ <string name="notification_channel_name_connected" msgid="1795068343200033922">"Godkendelse til loginportal"</string> <string name="notification_channel_description_connected" msgid="7239184168268014518">"De notifikationer, der vises, når enheden er blevet godkendt til et netværk via en loginportal"</string> <string name="notification_channel_name_network_venue_info" msgid="6526543187249265733">"Oplysninger om netværksplacering"</string> - <string name="notification_channel_description_network_venue_info" msgid="5131499595382733605">"Notifikationer, der vises for at indikere, at netværket har en side med oplysninger om lokationen"</string> + <string name="notification_channel_description_network_venue_info" msgid="5131499595382733605">"Notifikationer, der vises for at indikere, at netværket har en side med oplysninger om placeringen"</string> <string name="connected" msgid="4563643884927480998">"Der er oprettet forbindelse"</string> <string name="tap_for_info" msgid="6849746325626883711">"Der er oprettet forbindelse/tryk for at se website"</string> <string name="application_label" msgid="1322847171305285454">"Netværksadministrator"</string>
diff --git a/res/values-ky/strings.xml b/res/values-ky/strings.xml index bed0ea7..9aec881 100644 --- a/res/values-ky/strings.xml +++ b/res/values-ky/strings.xml
@@ -17,9 +17,9 @@ <resources xmlns:android="http://schemas.android.com/apk/res/android" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> <string name="notification_channel_name_connected" msgid="1795068343200033922">"Кирүү бетинин аутентификациясы"</string> - <string name="notification_channel_description_connected" msgid="7239184168268014518">"Түзмөк тармактын кирүү бети аркылуу аутентификациядан ийгиликтүү өткөндө билдирмелер көрүнөт"</string> + <string name="notification_channel_description_connected" msgid="7239184168268014518">"Түзмөк тармактын кирүү бети аркылуу аутентификациядан ийгиликтүү өткөндө билдирмелер көрсөтүлөт"</string> <string name="notification_channel_name_network_venue_info" msgid="6526543187249265733">"Тармактын жайгашуусу жөнүндө маалымат"</string> - <string name="notification_channel_description_network_venue_info" msgid="5131499595382733605">"Тармак маалымат барагына киргенде билдирме көрүнөт"</string> + <string name="notification_channel_description_network_venue_info" msgid="5131499595382733605">"Тармак маалымат барагына киргенде билдирме көрсөтүлөт"</string> <string name="connected" msgid="4563643884927480998">"Туташты"</string> <string name="tap_for_info" msgid="6849746325626883711">"Туташты / Вебсайтты көрүү үчүн таптаңыз"</string> <string name="application_label" msgid="1322847171305285454">"Тармактарды башкаргыч"</string>
diff --git a/res/values-ms/strings.xml b/res/values-ms/strings.xml index b5a08ec..e3b7121 100644 --- a/res/values-ms/strings.xml +++ b/res/values-ms/strings.xml
@@ -21,6 +21,6 @@ <string name="notification_channel_name_network_venue_info" msgid="6526543187249265733">"Maklumat tempat rangkaian"</string> <string name="notification_channel_description_network_venue_info" msgid="5131499595382733605">"Pemberitahuan dipaparkan untuk menunjukkan rangkaian mempunyai halaman maklumat tempat"</string> <string name="connected" msgid="4563643884927480998">"Disambungkan"</string> - <string name="tap_for_info" msgid="6849746325626883711">"Disambungkan / Ketik untuk melihat laman web"</string> + <string name="tap_for_info" msgid="6849746325626883711">"Disambungkan / Ketik untuk melihat tapak web"</string> <string name="application_label" msgid="1322847171305285454">"Pengurus rangkaian"</string> </resources>
diff --git a/src/android/net/apf/ApfFilter.java b/src/android/net/apf/ApfFilter.java index 7a13392..4d98568 100644 --- a/src/android/net/apf/ApfFilter.java +++ b/src/android/net/apf/ApfFilter.java
@@ -49,7 +49,6 @@ import android.net.metrics.ApfStats; import android.net.metrics.IpConnectivityLog; import android.net.metrics.RaEvent; -import android.net.util.InterfaceParams; import android.net.util.NetworkStackUtils; import android.os.PowerManager; import android.os.SystemClock; @@ -67,6 +66,7 @@ import com.android.internal.util.IndentingPrintWriter; import com.android.net.module.util.CollectionUtils; import com.android.net.module.util.ConnectivityUtils; +import com.android.net.module.util.InterfaceParams; import java.io.FileDescriptor; import java.io.IOException;
diff --git a/src/android/net/dhcp/DhcpClient.java b/src/android/net/dhcp/DhcpClient.java index 704ca7d..c88b653 100644 --- a/src/android/net/dhcp/DhcpClient.java +++ b/src/android/net/dhcp/DhcpClient.java
@@ -73,7 +73,6 @@ import android.net.metrics.IpConnectivityLog; import android.net.networkstack.aidl.dhcp.DhcpOption; import android.net.util.HostnameTransliterator; -import android.net.util.InterfaceParams; import android.net.util.NetworkStackUtils; import android.net.util.SocketUtils; import android.os.Build; @@ -99,6 +98,7 @@ import com.android.internal.util.StateMachine; import com.android.internal.util.WakeupMessage; import com.android.net.module.util.DeviceConfigUtils; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.NetworkStackConstants; import com.android.net.module.util.PacketReader; import com.android.networkstack.R;
diff --git a/src/android/net/ip/ConnectivityPacketTracker.java b/src/android/net/ip/ConnectivityPacketTracker.java index c02f7d3..a905315 100644 --- a/src/android/net/ip/ConnectivityPacketTracker.java +++ b/src/android/net/ip/ConnectivityPacketTracker.java
@@ -24,7 +24,6 @@ import static android.system.OsConstants.SOCK_RAW; import android.net.util.ConnectivityPacketSummary; -import android.net.util.InterfaceParams; import android.net.util.NetworkStackUtils; import android.os.Handler; import android.os.SystemClock; @@ -36,6 +35,7 @@ import com.android.internal.util.HexDump; import com.android.internal.util.TokenBucket; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.PacketReader; import java.io.FileDescriptor;
diff --git a/src/android/net/ip/IpClient.java b/src/android/net/ip/IpClient.java index 2ca26c1..a94e4cc 100644 --- a/src/android/net/ip/IpClient.java +++ b/src/android/net/ip/IpClient.java
@@ -73,7 +73,6 @@ import android.net.shared.ProvisioningConfiguration; import android.net.shared.ProvisioningConfiguration.ScanResultInfo; import android.net.shared.ProvisioningConfiguration.ScanResultInfo.InformationElement; -import android.net.util.InterfaceParams; import android.net.util.NetworkStackUtils; import android.net.util.SharedLog; import android.os.Build; @@ -107,6 +106,7 @@ import com.android.internal.util.StateMachine; import com.android.internal.util.WakeupMessage; import com.android.net.module.util.DeviceConfigUtils; +import com.android.net.module.util.InterfaceParams; import com.android.networkstack.R; import com.android.networkstack.apishim.NetworkInformationShimImpl; import com.android.networkstack.apishim.SocketUtilsShimImpl;
diff --git a/src/android/net/ip/IpClientLinkObserver.java b/src/android/net/ip/IpClientLinkObserver.java index adc527b..8a5ed2e 100644 --- a/src/android/net/ip/IpClientLinkObserver.java +++ b/src/android/net/ip/IpClientLinkObserver.java
@@ -36,7 +36,6 @@ import android.net.LinkAddress; import android.net.LinkProperties; import android.net.RouteInfo; -import android.net.util.InterfaceParams; import android.net.util.SharedLog; import android.os.Handler; import android.system.OsConstants; @@ -44,6 +43,7 @@ import androidx.annotation.NonNull; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.netlink.NduseroptMessage; import com.android.net.module.util.netlink.NetlinkConstants; import com.android.net.module.util.netlink.NetlinkMessage;
diff --git a/src/android/net/ip/IpReachabilityMonitor.java b/src/android/net/ip/IpReachabilityMonitor.java index c716fdf..076d73d 100644 --- a/src/android/net/ip/IpReachabilityMonitor.java +++ b/src/android/net/ip/IpReachabilityMonitor.java
@@ -33,7 +33,6 @@ import android.net.metrics.IpConnectivityLog; import android.net.metrics.IpReachabilityEvent; import android.net.networkstack.aidl.ip.ReachabilityLossReason; -import android.net.util.InterfaceParams; import android.net.util.SharedLog; import android.os.ConditionVariable; import android.os.Handler; @@ -54,6 +53,7 @@ import com.android.internal.annotations.VisibleForTesting; import com.android.internal.util.Preconditions; import com.android.net.module.util.DeviceConfigUtils; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.netlink.StructNdMsg; import com.android.networkstack.R; import com.android.networkstack.metrics.IpReachabilityMonitorMetrics;
diff --git a/src/com/android/server/connectivity/NetworkMonitor.java b/src/com/android/server/connectivity/NetworkMonitor.java index 977f907..301462f 100755 --- a/src/com/android/server/connectivity/NetworkMonitor.java +++ b/src/com/android/server/connectivity/NetworkMonitor.java
@@ -693,8 +693,7 @@ /** * Send a notification to NetworkMonitor indicating that the network is now connected. - * @Deprecated use notifyNetworkConnectedParcel. This method is called on R-, or in - * cases where the Connectivity module is old in S. + * @Deprecated use notifyNetworkConnectedParcel. This method is called on S-. */ public void notifyNetworkConnected(LinkProperties lp, NetworkCapabilities nc) { final NetworkMonitorParameters params = new NetworkMonitorParameters();
diff --git a/tests/integration/src/android/net/ip/IpClientIntegrationTestCommon.java b/tests/integration/src/android/net/ip/IpClientIntegrationTestCommon.java index 0ae7012..4d2a860 100644 --- a/tests/integration/src/android/net/ip/IpClientIntegrationTestCommon.java +++ b/tests/integration/src/android/net/ip/IpClientIntegrationTestCommon.java
@@ -132,7 +132,6 @@ import android.net.shared.Layer2Information; import android.net.shared.ProvisioningConfiguration; import android.net.shared.ProvisioningConfiguration.ScanResultInfo; -import android.net.util.InterfaceParams; import android.net.util.NetworkStackUtils; import android.net.util.SharedLog; import android.os.Build; @@ -156,6 +155,7 @@ import com.android.internal.util.HexDump; import com.android.internal.util.StateMachine; import com.android.net.module.util.ArrayTrackRecord; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.Ipv6Utils; import com.android.net.module.util.netlink.StructNdOptPref64; import com.android.net.module.util.structs.LlaOption;
diff --git a/tests/integration/src/android/net/util/NetworkStackUtilsIntegrationTest.kt b/tests/integration/src/android/net/util/NetworkStackUtilsIntegrationTest.kt index 0ec43a5..2dd984d 100644 --- a/tests/integration/src/android/net/util/NetworkStackUtilsIntegrationTest.kt +++ b/tests/integration/src/android/net/util/NetworkStackUtilsIntegrationTest.kt
@@ -38,6 +38,7 @@ import android.system.OsConstants.SOL_SOCKET import android.system.OsConstants.SO_RCVTIMEO import android.system.StructTimeval +import com.android.net.module.util.InterfaceParams import com.android.net.module.util.Ipv6Utils import com.android.net.module.util.NetworkStackConstants.ETHER_ADDR_LEN import com.android.net.module.util.NetworkStackConstants.IPV4_ADDR_ANY
diff --git a/tests/unit/Android.bp b/tests/unit/Android.bp index 7bb0d48..05a3260 100644 --- a/tests/unit/Android.bp +++ b/tests/unit/Android.bp
@@ -29,6 +29,7 @@ "kotlin-reflect", "mockito-target-extended-minus-junit4", "net-tests-utils", + //"net-utils-framework-common", "testables", ], libs: [
diff --git a/tests/unit/src/android/net/apf/ApfTest.java b/tests/unit/src/android/net/apf/ApfTest.java index b6de3a1..b2feaf1 100644 --- a/tests/unit/src/android/net/apf/ApfTest.java +++ b/tests/unit/src/android/net/apf/ApfTest.java
@@ -51,7 +51,6 @@ import android.net.ip.IpClient.IpClientCallbacksWrapper; import android.net.metrics.IpConnectivityLog; import android.net.metrics.RaEvent; -import android.net.util.InterfaceParams; import android.net.util.SharedLog; import android.os.ConditionVariable; import android.os.Parcelable; @@ -67,6 +66,7 @@ import com.android.internal.util.HexDump; import com.android.net.module.util.Inet4AddressUtils; +import com.android.net.module.util.InterfaceParams; import com.android.net.module.util.NetworkStackConstants; import com.android.networkstack.apishim.NetworkInformationShimImpl; import com.android.server.networkstack.tests.R;
diff --git a/tests/unit/src/android/net/ip/IpClientTest.java b/tests/unit/src/android/net/ip/IpClientTest.java index 37f12ca..481a957 100644 --- a/tests/unit/src/android/net/ip/IpClientTest.java +++ b/tests/unit/src/android/net/ip/IpClientTest.java
@@ -62,12 +62,12 @@ import android.net.shared.Layer2Information; import android.net.shared.ProvisioningConfiguration; import android.net.shared.ProvisioningConfiguration.ScanResultInfo; -import android.net.util.InterfaceParams; import android.os.Build; import androidx.test.filters.SmallTest; import androidx.test.runner.AndroidJUnit4; +import com.android.net.module.util.InterfaceParams; import com.android.networkstack.R; import com.android.server.NetworkObserver; import com.android.server.NetworkObserverRegistry;
diff --git a/tests/unit/src/android/net/ip/IpReachabilityMonitorTest.kt b/tests/unit/src/android/net/ip/IpReachabilityMonitorTest.kt index 0109022..ea64ca2 100644 --- a/tests/unit/src/android/net/ip/IpReachabilityMonitorTest.kt +++ b/tests/unit/src/android/net/ip/IpReachabilityMonitorTest.kt
@@ -25,7 +25,6 @@ import android.net.LinkProperties import android.net.RouteInfo import android.net.metrics.IpConnectivityLog -import android.net.util.InterfaceParams import android.net.util.NetworkStackUtils.IP_REACHABILITY_MCAST_RESOLICIT_VERSION import android.net.util.SharedLog import android.os.Handler @@ -54,6 +53,7 @@ import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 import com.android.networkstack.metrics.IpReachabilityMonitorMetrics +import com.android.net.module.util.InterfaceParams import com.android.net.module.util.netlink.StructNdMsg.NUD_FAILED import com.android.net.module.util.netlink.StructNdMsg.NUD_REACHABLE import com.android.net.module.util.netlink.StructNdMsg.NUD_STALE
diff --git a/tests/unit/src/android/net/util/InterfaceParamsTest.java b/tests/unit/src/android/net/util/InterfaceParamsTest.java deleted file mode 100644 index dc70bd0..0000000 --- a/tests/unit/src/android/net/util/InterfaceParamsTest.java +++ /dev/null
@@ -1,56 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package android.net.util; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; - -import androidx.test.filters.SmallTest; -import androidx.test.runner.AndroidJUnit4; - -import com.android.net.module.util.NetworkStackConstants; - -import org.junit.Test; -import org.junit.runner.RunWith; - -@RunWith(AndroidJUnit4.class) -@SmallTest -public class InterfaceParamsTest { - @Test - public void testNullInterfaceReturnsNull() { - assertNull(InterfaceParams.getByName(null)); - } - - @Test - public void testNonExistentInterfaceReturnsNull() { - assertNull(InterfaceParams.getByName("doesnotexist0")); - } - - @Test - public void testLoopback() { - final InterfaceParams ifParams = InterfaceParams.getByName("lo"); - assertNotNull(ifParams); - assertEquals("lo", ifParams.name); - assertTrue(ifParams.index > 0); - assertNotNull(ifParams.macAddr); - assertFalse(ifParams.hasMacAddress); - assertTrue(ifParams.defaultMtu >= NetworkStackConstants.ETHER_MTU); - } -}