commit e752407bfb02f275005fa09423d2209992c7ed7b
author Chiachang Wang <chiachangwang@google.com> Mon Apr 26 08:36:00 2021 +0800
committer Chiachang Wang <chiachangwang@google.com> Mon Apr 26 08:36:00 2021 +0800
tree 9b1a9dcddf43d31451d631d8a621ef963f92ace0
parent 445e38163c42ad1974925f30286a7ccb93581dfb

Set last probing time to always evaluate stall

isDataStall() will skip the stall check if NetworkMonitor sent
probe within the minimal evaluation time to prevent sending
probing too frequently. In differnent test targets, the probing
result may come back just before test tries to check wether
it's stall or not. It may result in the unexpected result.
Set the last probing time to always evaluate it since the test
does not try to exam that part.

Bug: 185082309
Test: atest NetworkMonitorTest in forrest for 20 sets
Change-Id: I52a215e9c5be2c0f069ca24f800d4d616bb437d8

tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java

diff --git a/tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java b/tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java
index 2735fb6..790043e 100644
--- a/tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java
+++ b/tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java
@@ -2023,6 +2023,8 @@
                 ArgumentCaptor.forClass(DataStallDetectionStats.class);
         verify(mDependencies, timeout(HANDLER_TIMEOUT_MS).times(1))
                 .writeDataStallDetectionStats(statsCaptor.capture(), probeResultCaptor.capture());
+        // Ensure probe will not stop due to rate-limiting mechanism.
+        nm.setLastProbeTime(SystemClock.elapsedRealtime() - 1000);
         assertTrue(nm.isDataStall());
         assertTrue(probeResultCaptor.getValue().isSuccessful());
         verifyTestDataStallDetectionStats(evalType, transport, statsCaptor.getValue());