Early "return" / continue to reduce indentation
For readbility.
Test: TH
Flag: EXEMPT mainline
Bug: 1000001
Change-Id: I140eabc49b4b8a61e24d4b7ec8465c92a919f485
diff --git a/dns_proxy/server/driver.rs b/dns_proxy/server/driver.rs
index 0aa7bc2..78ce2f9 100644
--- a/dns_proxy/server/driver.rs
+++ b/dns_proxy/server/driver.rs
@@ -276,21 +276,25 @@
let mut buf = [0u8; 0xffff];
loop {
let (packet_size, client_addr) = socket.recv_from(&mut buf).await?;
- if let Ok(query_packet) = DnsPacket::try_from(buf[0..packet_size].to_vec()) {
- let command_tx = match weak_command_tx.upgrade() {
- Some(t) => t,
- None => return Err(Error::ServerStopped),
- };
+ let query_packet = match DnsPacket::try_from(buf[0..packet_size].to_vec()) {
+ Ok(query_packet) => query_packet,
+ // The received packet is not a DnsPacket. Continue.
+ Err(_) => continue,
+ };
- let _ = command_tx
- .send(Command::ForwardUdpQuery(UdpDnsQuery::new(
- query_packet,
- index_port,
- client_addr,
- Arc::downgrade(&socket),
- )))
- .await;
- }
+ let command_tx = match weak_command_tx.upgrade() {
+ Some(t) => t,
+ None => return Err(Error::ServerStopped),
+ };
+
+ let _ = command_tx
+ .send(Command::ForwardUdpQuery(UdpDnsQuery::new(
+ query_packet,
+ index_port,
+ client_addr,
+ Arc::downgrade(&socket),
+ )))
+ .await;
}
})
}
