Google Git
Sign in
android / platform / packages / modules / DnsResolver / 4730f0d78f347dee78087f4849e19816fe4827a0
commit4730f0d78f347dee78087f4849e19816fe4827a0[log] [tgz]
authorKen Chen <cken@google.com>Tue May 09 17:53:36 2023 +0800
committerKen Chen <cken@google.com>Tue May 09 17:53:36 2023 +0800
tree03e1a08b754aa7be41798edc16036e58a397bdc2
parent2c10321e203c19b4b6bf301d76eb1e57fa964e57 [diff]
Fix -Wnullable-to-nonnull-conversion errors

Aosp/2566619 added Nonnull annotations in strcasecmp, which causes build
break in DNS resolver module and tests.

This commit:
1. Checks if a nullable variable is null before passing it to the
   strcasecmp.
2. Adds a hacky way to avoid -Wnullable-to-nonnull-conversion errors.

Bug: 278513807
Test: presubmit
Change-Id: I146f5b91114dd7c934c9e3fb12477e4563005c5f
2 files changed
tree: 03e1a08b754aa7be41798edc16036e58a397bdc2
  1. aidl_api/
  2. apex/
  3. binder/
  4. doh/
  5. include/
  6. tests/
  7. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  8. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  9. .editorconfig
  10. Android.bp
  11. cbindgen.toml
  12. Dns64Configuration.cpp
  13. Dns64Configuration.h
  14. DnsProxyListener.cpp
  15. DnsProxyListener.h
  16. DnsQueryLog.cpp
  17. DnsQueryLog.h
  18. DnsQueryLogTest.cpp
  19. DnsResolver.cpp
  20. DnsResolver.h
  21. DnsResolverService.cpp
  22. DnsResolverService.h
  23. DnsStats.cpp
  24. DnsStats.h
  25. DnsStatsTest.cpp
  26. DnsTlsDispatcher.cpp
  27. DnsTlsDispatcher.h
  28. DnsTlsQueryMap.cpp
  29. DnsTlsQueryMap.h
  30. DnsTlsServer.cpp
  31. DnsTlsServer.h
  32. DnsTlsSessionCache.cpp
  33. DnsTlsSessionCache.h
  34. DnsTlsSocket.cpp
  35. DnsTlsSocket.h
  36. DnsTlsSocketFactory.h
  37. DnsTlsTransport.cpp
  38. DnsTlsTransport.h
  39. doh.h
  40. Experiments.cpp
  41. Experiments.h
  42. ExperimentsTest.cpp
  43. getaddrinfo.cpp
  44. getaddrinfo.h
  45. gethnamaddr.cpp
  46. gethnamaddr.h
  47. hostent.h
  48. IDnsTlsSocket.h
  49. IDnsTlsSocketFactory.h
  50. IDnsTlsSocketObserver.h
  51. libnetd_resolv.map.txt
  52. LockedQueue.h
  53. NOTICE
  54. OperationLimiter.h
  55. OperationLimiterTest.cpp
  56. OWNERS
  57. params.h
  58. PREUPLOAD.cfg
  59. PrivateDnsCommon.h
  60. PrivateDnsConfiguration.cpp
  61. PrivateDnsConfiguration.h
  62. PrivateDnsConfigurationTest.cpp
  63. PrivateDnsValidationObserver.h
  64. README-DoT.md
  65. README.md
  66. res_cache.cpp
  67. res_comp.cpp
  68. res_comp.h
  69. res_debug.cpp
  70. res_debug.h
  71. res_mkquery.cpp
  72. res_query.cpp
  73. res_send.cpp
  74. res_send.h
  75. res_stats.cpp
  76. resolv_cache.h
  77. resolv_private.h
  78. resolv_test_config_template.xml
  79. resolv_test_config_without_root_template.xml
  80. ResolverController.cpp
  81. ResolverController.h
  82. ResolverEventReporter.cpp
  83. ResolverEventReporter.h
  84. ResolverStats.h
  85. sethostent.cpp
  86. stats.h
  87. stats.proto
  88. TEST_MAPPING
  89. util.cpp
  90. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.