commit 5e980f4e3dbff6b1e7acd0de9ceb2e06ba5f4ef8
author Varun Anand <vaanand@google.com> Thu Feb 07 14:13:13 2019 -0800
committer Varun Anand <vaanand@google.com> Fri Mar 01 00:10:52 2019 +0000
tree f7b0b762e6cff6204d5ae23c8a873611a46f22ba
parent e239dc818c5ada92377d6006732037fc879a0967

Remove ConnectivityManager and its usages from NetworkStatsService.

NSS needed it for getting VpnInfo[], NetworkState[] and
activeLinkProperties which it used to query via ConnectivityManager.

For VpnInfo[], this was racy as NSS may ignore intermediate changes to a
VPN's underlying networks. See http://b/123961098 for more context.

It may also lead to deadlocks b/w ConnectivityService and
NetworkStatsService. See http://b/126245192 for more info.

This change will ensure that NSS is never contending on any of
ConnectivityService locks.

Bug: 123961098
Bug: 126245192
Bug: 120145746
Test: atest FrameworksNetTests
Change-Id: Id1da446b54d95ee68ed14079107b1a10318bcf8b
Merged-In: I57e117bb4e9efe491b19d6b5a479f2d58d1c58e6