tree 412000a09bcb4e1391dba04f120652a4f184b847
parent dd7df788e828c8427259b36c443b552df13178f2
author Benedict Wong <benedictwong@google.com> 1551414528 -0800
committer Benedict Wong <benedictwong@google.com> 1554774710 -0700

Fix remove-before-add for IpSecService RefcountedResource

This patch fixes a bug where if a binder dies before the linkToDeath
call, the cleanup will be performed before the entry is added to the
array. While it is safe in that quotas and tracking performs as per
normal, the RefcountedRecord may not be cleaned up.

Rethrowing this exception is safe, since the only paths that would hit
this are all on binder threads coming from applications. Further, it
seems there is only one real way of this getting hit - if the app that
called the creation died during the binder call.

Bug: 126802451
Test: Compiled, CTS tests passing
Change-Id: I6db75853da9f29e1573512e26351623f22770c5d