Fix ErrorLogUtil logging verification issues in tests.
All uses cases of @SkipLoggingUsageRule are resulting in the entire test to be skipped, rather than just the rule. This hides isues from other possible assertions that could be failing. Upon fixing this, a few other issues (which would be failing if @SkipLoggingUsageRule wasn't used) were detected. Specifically, the usage of ErrorLogUtilCallback used for background log verification, which is the primary reason why @SkipLoggingUsageRule is used.
Incorrect usages of ErrorLogUtilCallback were fixed. This required
supporting multiple invocation verification. Several other tests were also fixed
which were masked due to usage of annotation. Couple were commented out
for a follow-up with the test owner.
Also took this opportunity to deprecate ErrorLogUtilInvocation in favor
of ErrorLogUtilCall so throwable equality is based on the class name
rather than the actual object itself.
Bug: 381931308
Bug: 381938364
Bug: 382553602
Bug: 355696393
FLAG: TEST_ONLY
BYPASS_PS_FLAG_CHECK: test-only change
Test: atest ErrorLogUtilCallTest ersistAdSelectionResultRunnerTest GetAdSelectionDataRunnerTest AbstractLoggingUsageRuleTest CustomAudienceServiceImplTest
Change-Id: If02512638c6ba302e26c1e8be4c79fb9313c010b
14 files changed
