tree 4690a53189c588b773825c4347edc6c9cefd027e
parent 2c6a4c21fe3ff2be544d3a5b8ee544ac7474e3dd
author Catherine Liang <cathliang@google.com> 1694122215 +0000
committer Catherine Liang <cathliang@google.com> 1694182160 +0000

Fix color picker scroll position resets on selecti (2/2)

After a color option is selected in the color picker, the scroll
position jumps back to the start, rather than saving and restoring the
scroll position using save and restore instance state. The regression
was caused by a combination of 1) color picker restarting twice from
config change updates, 2) the view.post callback not being removed when
the view is destroyed, leading to two consecutive calls, and 3) recycler
view's restore instance state was called before the data was fully
binded. The code to update color options on selection was
also removed for now because it interferes with the config change
restart and saving instance state. This should be brought back once the
config change restart is disabled.

Bug: 298898592
Test: manually verified
Change-Id: Id006cea1922b6b4d5c27f06901e39a8e3bcd853e