Remove nested repeatOnLifecycle calls

The nested repeatOnLifecycle calls caused the flow collectors to increase with every repetition of the lifecycle. This had significant performance impact, mainly on the onStop lifecycle callback duration. CustomizationPickerActivity onStop could take 200ms or more whereas with this fix it is mostly below 20ms.

Bug: 281021563
Test: Manual, i.e. measuring Activity onStop duration with logs and perfetto
Change-Id: Ic2ad4f6ff8188304092deab17bd3739c564004b1
1 file changed