Secure the pendingIntent in SearchWidgetProvider.
Fixes - "PendingIntent in QuickSearchBox Widget ..." security bug.
This change is similar to the fix to Settings changes.
+ Assign the package name for pending intent, so that the intent
only can launch the QuicSearchBox app.
https://googleplex-android-review.git.corp.google.com/c/platform/packages/apps/Settings/+/10526147/2/src/com/android/settings/slices/SettingsSliceProvider.java
git_qt-dev:
https://android-build.googleplex.com/builds/abtd/run/L35800000951088353
git_rvc-dev:
https://android-build.googleplex.com/builds/abtd/run/L61000000951079598
git_sc-dev:
https://android-build.googleplex.com/builds/abtd/run/L60400000951091431
+ Assign the package name for pending intent, so that the intent
only can launch the QuicSearchBox app.
Original aosp-master cl: aosp/1818517
Fix: 184046278
Test: manual
+ Verified the above bug is fixes the above bug,
+ Installed the app and verified search is working.
$ m
$ ls -l ./out/target/product/bonito/product/app/QuickSearchBox/QuickSearchBox.apk-rw-r--r-- 1 rtenneti primarygroup 701136 Sep 3 14:52 ./out/target/product/bonito/product/app/QuickSearchBox/QuickSearchBox.apk
$ adb install -t ./out/target/product/bonito/product/app/QuickSearchBox/QuickSearchBox.apk
Performing Streamed Install
Success
$ make QuickSearchBoxTests
$ ls -l out/target/product/bonito/testcases/QuickSearchBoxTests/arm64/QuickSearchBox*
-rw-r--r-- 1 rtenneti primarygroup 33175 Sep 3 16:40 out/target/product/bonito/testcases/QuickSearchBoxTests/arm64/QuickSearchBoxTests.apk
$ adb shell am instrument -w com.android.quicksearchbox.tests
com.android.quicksearchbox.CachingIconLoaderTest:.
com.android.quicksearchbox.LevenshteinFormatterTest:.........................
com.android.quicksearchbox.PackageIconLoaderTest:..
com.android.quicksearchbox.SuggestionUtilsTest:......
com.android.quicksearchbox.util.CachedLaterTest:......
com.android.quicksearchbox.util.LevenshteinDistanceTest:.....
com.android.quicksearchbox.util.PerNameExecutorTest:...
com.android.quicksearchbox.util.PriorityThreadFactoryTest:.
com.android.quicksearchbox.util.SingleThreadNamedTaskExecutorTest:.
Test results for InstrumentationTestRunner=.........................................
.........
Time: 0.277
OK (50 tests)
Bug: 184046278
Change-Id: Idf5592b14967c6567e898b0b23a5e18f8209f639
1 file changed