commit cfc6b97c7d4dbaf7a50433a0f459ee4e25725e82
author Anthony Hugh <ahugh@google.com> Fri Dec 04 13:30:49 2015 -0800
committer Anthony Hugh <ahugh@google.com> Fri Dec 04 13:44:07 2015 -0800
tree 36baebead202fdece1df84168e3df5761ebf5ac6
parent 741ac03b4367c06d33190b80e2f6a6003a803517

Fix wake lock leak

Wake lock was not being released when installation failed
due to early bail out call.  I wrapped the calls into
a try/finally to ensure it gets released.

Code was tested by tweaking the code to force a failure
and test installing/uninstalling apps.

BUG: 25814793
Change-Id: I2e81e5d76edcfb601ce734cf571705e979c51f32

src/com/android/packageinstaller/wear/WearPackageInstallerService.java

diff --git a/src/com/android/packageinstaller/wear/WearPackageInstallerService.java b/src/com/android/packageinstaller/wear/WearPackageInstallerService.java
index 6dc5aa7..229a3df 100644
--- a/src/com/android/packageinstaller/wear/WearPackageInstallerService.java
+++ b/src/com/android/packageinstaller/wear/WearPackageInstallerService.java
@@ -586,31 +586,33 @@
         }
 
         public void packageInstalled(String packageName, int returnCode) {
-            // If installation failed, bail out and remove the ShowPermsStore entry
-            if (returnCode < 0) {
-                Log.e(TAG, "Package install failed " + mApplicationPackageName
-                        + ", returnCode " + returnCode);
-                WearPackageUtil.removeFromPermStore(mContext, mApplicationPackageName);
-                return;
+            try {
+                // If installation failed, bail out and remove the ShowPermsStore entry
+                if (returnCode < 0) {
+                    Log.e(TAG, "Package install failed " + mApplicationPackageName
+                            + ", returnCode " + returnCode);
+                    WearPackageUtil.removeFromPermStore(mContext, mApplicationPackageName);
+                    return;
+                }
+
+                Log.i(TAG, "Package " + packageName + " was installed.");
+
+                // Delete tempFile from the file system.
+                File tempFile = WearPackageUtil.getTemporaryFile(mContext, packageName);
+                if (tempFile != null) {
+                    tempFile.delete();
+                }
+
+                // Broadcast the "UPDATED" gmscore intent, normally sent by play store.
+                // TODO: Remove this broadcast if/when we get the play store to do this for us.
+                if (GMS_PACKAGE_NAME.equals(packageName)) {
+                    Intent gmsInstalledIntent = new Intent(GMS_UPDATED_BROADCAST);
+                    gmsInstalledIntent.setPackage(GMS_PACKAGE_NAME);
+                    mContext.sendBroadcast(gmsInstalledIntent);
+                }
+            } finally {
+                finishService(mWakeLock, mStartId);
             }
-
-            Log.i(TAG, "Package " + packageName + " was installed.");
-
-            // Delete tempFile from the file system.
-            File tempFile = WearPackageUtil.getTemporaryFile(mContext, packageName);
-            if (tempFile != null) {
-                tempFile.delete();
-            }
-
-            // Broadcast the "UPDATED" gmscore intent, normally sent by play store.
-            // TODO: Remove this broadcast if/when we get the play store to do this for us.
-            if (GMS_PACKAGE_NAME.equals(packageName)) {
-                Intent gmsInstalledIntent = new Intent(GMS_UPDATED_BROADCAST);
-                gmsInstalledIntent.setPackage(GMS_PACKAGE_NAME);
-                mContext.sendBroadcast(gmsInstalledIntent);
-            }
-
-            finishService(mWakeLock, mStartId);
         }
     }
 
@@ -624,13 +626,16 @@
         }
 
         public void packageDeleted(String packageName, int returnCode) {
-            if (returnCode >= 0) {
-                Log.i(TAG, "Package " + packageName + " was uninstalled.");
-            } else {
-                Log.e(TAG, "Package uninstall failed " + packageName + ", returnCode " +
-                        returnCode);
+            try {
+                if (returnCode >= 0) {
+                    Log.i(TAG, "Package " + packageName + " was uninstalled.");
+                } else {
+                    Log.e(TAG, "Package uninstall failed " + packageName + ", returnCode " +
+                            returnCode);
+                }
+            } finally {
+                finishService(mWakeLock, mStartId);
             }
-            finishService(mWakeLock, mStartId);
         }
     }
 }