)]}' { "commit": "0d53b02d23f7dcce4a109a42dae5f3359db54bcd", "tree": "8a29aeba2d993b3b3bec9307651bd6c2c6b412e5", "parents": [ "0ab476cb92a7c2e826be60d9572964519eec5da8" ], "author": { "name": "Sunny Goyal", "email": "sunnygoyal@google.com", "time": "Fri Aug 06 11:52:10 2021 -0700" }, "committer": { "name": "Android Build Coastguard Worker", "email": "android-build-coastguard-worker@google.com", "time": "Wed Sep 15 00:10:50 2021 +0000" }, "message": "Fixing ModelPreload cancelling existing load\n\nWhen a model preload call was made while the loader task is running\n(eg: on enabling/disabling icon theme, Launcher reloads and then\nlauncher preview start a model-preload), it would cancel the original\nloader and then start a new loader with empty callbacks. So the\nmodel indeed get loaded, but the original callbacks never got notified\nof it.\n\n\u003e Instead we only start preload if an existing task is not running.\n\u003e Also when preloading, we use existing callbacks, instead of using\n empty callbacks\n\nBug: 193851085\nBug: 195155924\nTest: Verified repro steps\nChange-Id: I0a96310be8489756f364aa2a12e4345e1418733d\n(cherry picked from commit 57d4f748b89b2a07e2b33acdfdbcc3767df0aa41)\n", "tree_diff": [ { "type": "modify", "old_id": "eef3980f969d6dffaa787c4c7e01a82f26522765", "old_mode": 33188, "old_path": "src/com/android/launcher3/LauncherModel.java", "new_id": "545f4c39996aea463e729230fe22db8062f7850f", "new_mode": 33188, "new_path": "src/com/android/launcher3/LauncherModel.java" }, { "type": "modify", "old_id": "df493599ede21195c9eb725e97f164f40e641d67", "old_mode": 33188, "old_path": "src/com/android/launcher3/graphics/PreviewSurfaceRenderer.java", "new_id": "3b140a06bdd07aeb8833f716e28403b737b53606", "new_mode": 33188, "new_path": "src/com/android/launcher3/graphics/PreviewSurfaceRenderer.java" }, { "type": "delete", "old_id": "756b7da759a02f57261cd25140f8372825cdfb07", "old_mode": 33188, "old_path": "src/com/android/launcher3/model/ModelPreload.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" } ] }