commit a998fc6b1b2ff8da5ae427d28818813c361c12db
author Hyein Yu <hyeinyu@google.com> Thu Sep 26 23:16:15 2024 +0000
committer Hyein Yu <hyeinyu@google.com> Thu Sep 26 23:16:15 2024 +0000
tree 4d602827c0ac1c41105de5fdc7ba76b55fb609e8
parent fab191b3d7c37222c271a5bdc07565bc9468aaa3

Fix exception for getActiveSubscriptionInfo() in CellBroadcastReceiverOemUnitTests

Mocking for getActiveSubscriptionInfo() of SubscriptionManager should be added

Bug: 369737253
Test: atest com.android.cellbroadcastreceiver.unit.CellBroadcastAlertSettingsTest
Flag: TEST_ONLY
Change-Id: I20d938ce47fbc49b563d1bf0e1e10c4fc81d9032

tests/unit/src/com/android/cellbroadcastreceiver/unit/CellBroadcastSettingsTest.java

diff --git a/tests/unit/src/com/android/cellbroadcastreceiver/unit/CellBroadcastSettingsTest.java b/tests/unit/src/com/android/cellbroadcastreceiver/unit/CellBroadcastSettingsTest.java
index 7402059..3601dde 100644
--- a/tests/unit/src/com/android/cellbroadcastreceiver/unit/CellBroadcastSettingsTest.java
+++ b/tests/unit/src/com/android/cellbroadcastreceiver/unit/CellBroadcastSettingsTest.java
@@ -104,6 +104,10 @@
         mDevice = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation());
         MockitoAnnotations.initMocks(this);
         CellBroadcastSettings.resetResourcesCache();
+        SubscriptionManager mockSubManager = mock(SubscriptionManager.class);
+        injectSystemService(SubscriptionManager.class, mockSubManager);
+        SubscriptionInfo mockSubInfo = mock(SubscriptionInfo.class);
+        doReturn(mockSubInfo).when(mockSubManager).getActiveSubscriptionInfo(anyInt());
     }
 
     @After
@@ -371,7 +375,6 @@
         String topIntroRoamingText = "test";
         doReturn(topIntroRoamingText).when(mContext.getResources()).getString(
                 eq(R.string.top_intro_roaming_text));
-        setSubscriptionManager();
         setPreference(PREFERENCE_PUT_TYPE_STRING, ROAMING_OPERATOR_SUPPORTED, "XXX");
 
         CellBroadcastSettings settings = startActivity();
@@ -383,7 +386,6 @@
 
     @Test
     public void testDoNotShowTestCheckBox() throws Throwable {
-        setSubscriptionManager();
         setPreference(PREFERENCE_PUT_TYPE_BOOL, TESTING_MODE, "false");
         doReturn(false).when(mContext.getResources()).getBoolean(
                 eq(R.bool.show_separate_exercise_settings));
@@ -419,7 +421,6 @@
 
     @Test
     public void testShowTestCheckBox() throws Throwable {
-        setSubscriptionManager();
         setPreference(PREFERENCE_PUT_TYPE_BOOL, TESTING_MODE, "true");
         doReturn(true).when(mContext.getResources()).getBoolean(
                 eq(R.bool.show_separate_exercise_settings));
@@ -455,13 +456,6 @@
         assertTrue(operatorDefinedCheckBox.isVisible());
     }
 
-    private void setSubscriptionManager() {
-        SubscriptionManager mockSubManager = mock(SubscriptionManager.class);
-        injectSystemService(SubscriptionManager.class, mockSubManager);
-        SubscriptionInfo mockSubInfo = mock(SubscriptionInfo.class);
-        doReturn(mockSubInfo).when(mockSubManager).getActiveSubscriptionInfo(anyInt());
-    }
-
     private void setPreference(int putType, String key, String value) {
         mContext.injectSharedPreferences(mFakeSharedPreferences);
         switch (putType) {