Google Git
Sign in
android / platform / libnativehelper / 31a261d502eeac8ffe7b03829f2450c8fb794c9c
commit31a261d502eeac8ffe7b03829f2450c8fb794c9c[log] [tgz]
authorJiakai Zhang <jiakaiz@google.com>Mon Sep 25 14:52:00 2023 +0100
committerJiakai Zhang <jiakaiz@google.com>Tue Jan 02 21:26:55 2024 +0000
tree899a2d71e3fd4029dedb2552f696933d8edcfad6
parent3b58c4334a0d98313e2620377c9abb11b6e40e44 [diff]
Fix the use-after-free issue with CREATE_UTF_OR_RETURN.

Before this change, if `expr` creates temporary objects, the objects
were destroyed as soon as the first line of the macro was evaluated,
causing a use-after-free issue. This CL fixes it using a lambda
expression.

Bug: 301377542
Test: Run `atest MtsLibnativehelperTestCases` on an hwasan build.
Change-Id: I4ee4162f78ea949bfbe42282034d47dc5d0a0c4d
Merged-In: I4ee4162f78ea949bfbe42282034d47dc5d0a0c4d
2 files changed
tree: 899a2d71e3fd4029dedb2552f696933d8edcfad6
  1. header_only_include/
  2. include/
  3. include_jni/
  4. include_platform/
  5. include_platform_header_only/
  6. tests/
  7. tests_mts/
  8. ALog-priv.h
  9. Android.bp
  10. DlHelp.c
  11. DlHelp.h
  12. ExpandableString.c
  13. ExpandableString.h
  14. file_descriptor_jni.c
  15. JniConstants.c
  16. JniConstants.h
  17. JNIHelp.c
  18. JniInvocation-priv.h
  19. JniInvocation.c
  20. JNIPlatformHelp.c
  21. libnativehelper.map.txt
  22. libnativehelper_lazy.c
  23. libnativehelper_lazy.h
  24. NOTICE
  25. OWNERS
  26. PREUPLOAD.cfg
  27. README.md
  28. TEST_MAPPING
README.md

libnativehelper

libnativehelper is a collection of JNI related utilities used in Android.

There are several header and binary libraries here and not all of the functionality fits together well. The header libraries are mostly C++ based. The binary libraries are entirely written in C with no C++ dependencies. This is by design as the code here can be distributed in multiple ways, including mainline modules, so keeping the size down benefits everyone with smaller downloads and a stable ABI.

Header Libraries

jni_headers

This is a header library that contains provides the API represented in the JNI Specification 1.6. Any project in Android that depends on jni.h should depend on this.

See:

libnativehelper_header_only

These headers provide utilities that defined entirely within the headers. There are scoped resource classes that make common JNI patterns of acquiring and releasing resources safer to use than the JNI specification equivalents. Examples being ScopedLocalRef to manage the lifetime of local references and ScopedUtfChars to manage the lifetime of Java strings in native code and provide access to utf8 characters.

See:

jni_platform_headers

The jni_macros.h header provide compile time checking of JNI methods implemented in C++. They ensure the C++ method declaration match the Java signature they are associated with.

See:

Libraries

libnativehelper

A shared library distributed in the ART module that provides helper routines built on Java APIs. This library depends on details that are private to libcore and use should be restricted to platform code and within the ART module.

This library also contains the JNI invocation API from the JNI Specification and the glue that connects the ART runtime to the API implementation. The glue logic is platform only as it is used with the Zygote and the standalone dalvikvm.

See:

libnativehelper_compat_libc++

This shared and static library contains a subset of the helper routines in libnativehelper based on public Java API. This code can be statically linked as the Java APIs it depends on are considered stable. The name of this library is a misnomer since it contains no C++ code.

See: