tree 3964120c858eac3bc8093868d5471388346d9f08
parent 31651e7a39b8c79cacebda5439d25715a02aa7cf
author Narayan Kamath <narayan@google.com> 1449923894 +0000
committer Narayan Kamath <narayan@google.com> 1450087175 +0000

Simplify AbstractPreferences.

There's no need for a complicated re-implementation of copy
on write lists. Simple ArrayLists will suffice; all operations
are guarded by |lock| and we can return a copy of the list to
the Event processor thread to avoid concurrent modification of
the list while that thread is dispatching events.

Fixes various preference tests related to adding / removing
duplicate listeners.

A notable difference in behaviour here is that listeners are
now compared using their equals() method and not using reference
equality.

bug: 26023763
bug: 25996530

Change-Id: I57ee723cf926786e1f119ec1e7740c66162ab749