commit a0658795cfdba369c9cef84c011123932519acfb
author Matthias Baesken <mbaesken@openjdk.org> Wed Feb 17 13:49:30 2021 +0000
committer Matthias Baesken <mbaesken@openjdk.org> Wed Feb 17 13:49:30 2021 +0000
tree d54220d7c7217a4c1c2bd77113dad712fe6802c7
parent 9ba2b71a6154c8803c768fe4f5caedddebb47299

8261791: (sctp) handleSendFailed in SctpChannelImpl.c potential leaks

Reviewed-by: chegar, alanb

src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c

diff --git a/src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c b/src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c
index 350a0d0..2897c22 100644
--- a/src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c
+++ b/src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c
@@ -229,7 +229,10 @@
         msg->msg_iovlen = 1;
 
         bufferObj = (*env)->NewDirectByteBuffer(env, addressP, dataLength);
-        CHECK_NULL(bufferObj);
+        if (bufferObj == NULL) {
+            free(addressP);
+            return;
+        }
 
         alreadyRead = read - dataOffset;
         if (alreadyRead > 0) {
@@ -243,12 +246,14 @@
 
         if (remaining > 0) {
             if ((rv = recvmsg(fd, msg, 0)) < 0) {
+                free(addressP);
                 handleSocketError(env, errno);
                 return;
             }
 
             if (rv != (dataLength - alreadyRead) || !(msg->msg_flags & MSG_EOR)) {
                 //TODO: assert false: "should not reach here";
+                free(addressP);
                 return;
             }
             // TODO: Set and document (in API) buffers position.
@@ -258,7 +263,10 @@
     /* create SendFailed */
     resultObj = (*env)->NewObject(env, ssf_class, ssf_ctrID, ssf->ssf_assoc_id,
             isaObj, bufferObj, ssf->ssf_error, sri->sinfo_stream);
-    CHECK_NULL(resultObj);
+    if (resultObj == NULL) {
+        if (bufferObj != NULL) free(addressP);
+        return;
+    }
     (*env)->SetObjectField(env, resultContainerObj, src_valueID, resultObj);
     (*env)->SetIntField(env, resultContainerObj, src_typeID,
             sun_nio_ch_sctp_ResultContainer_SEND_FAILED);