commit 7b1c8be3d3c05e2ecd4eb93df040536f1142b2fe
author Xue-Lei Andrew Fan <xuelei@openjdk.org> Tue Jul 19 21:47:23 2011 -0700
committer Xue-Lei Andrew Fan <xuelei@openjdk.org> Tue Jul 19 21:47:23 2011 -0700
tree 81e7d35a0fac4c98c7a20489f843293697bc8eec
parent f106ea9ed69409e594e1892b7201f4c2cdd92dc3

7065972: Some race condition may happen in SSLSocketImpl class

Reviewed-by: wetmore, weijun, dgu

jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java

diff --git a/jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java b/jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java
index d12eaf1..8990793 100644
--- a/jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java
+++ b/jdk/src/share/classes/sun/security/ssl/SSLSocketImpl.java
@@ -2443,11 +2443,12 @@
             entrySet, HandshakeCompletedEvent e) {
 
             super("HandshakeCompletedNotify-Thread");
-            targets = entrySet;
+            targets = new HashSet<>(entrySet);          // clone the entry set
             event = e;
         }
 
         public void run() {
+            // Don't need to synchronize, as it only runs in one thread.
             for (Map.Entry<HandshakeCompletedListener,AccessControlContext>
                 entry : targets) {