8250914: Matcher::stack_direction() is unused
Remove unused Matcher::stack_direction() together with related ADL entries and
ADLC support.
Reviewed-by: vlivanov, thartmann
diff --git a/src/hotspot/cpu/aarch64/aarch64.ad b/src/hotspot/cpu/aarch64/aarch64.ad
index fb9929e..234f0f5 100644
--- a/src/hotspot/cpu/aarch64/aarch64.ad
+++ b/src/hotspot/cpu/aarch64/aarch64.ad
@@ -4043,9 +4043,6 @@
// SP meets the minimum alignment.
frame %{
- // What direction does stack grow in (assumed to be same for C & Java)
- stack_direction(TOWARDS_LOW);
-
// These three registers define part of the calling convention
// between compiled code and the interpreter.
diff --git a/src/hotspot/cpu/arm/arm.ad b/src/hotspot/cpu/arm/arm.ad
index d0a82e4..2236be8 100644
--- a/src/hotspot/cpu/arm/arm.ad
+++ b/src/hotspot/cpu/arm/arm.ad
@@ -1664,9 +1664,6 @@
// the region from SP to FP meets the minimum stack alignment.
frame %{
- // What direction does stack grow in (assumed to be same for native & Java)
- stack_direction(TOWARDS_LOW);
-
// These two registers define part of the calling convention
// between compiled code and the interpreter.
inline_cache_reg(R_Ricklass); // Inline Cache Register or Method* for I2C
diff --git a/src/hotspot/cpu/ppc/ppc.ad b/src/hotspot/cpu/ppc/ppc.ad
index 0258118..5915a3b 100644
--- a/src/hotspot/cpu/ppc/ppc.ad
+++ b/src/hotspot/cpu/ppc/ppc.ad
@@ -4118,9 +4118,6 @@
// Definition of frame structure and management information.
frame %{
- // What direction does stack grow in (assumed to be same for native & Java).
- stack_direction(TOWARDS_LOW);
-
// These two registers define part of the calling convention between
// compiled code and the interpreter.
diff --git a/src/hotspot/cpu/s390/s390.ad b/src/hotspot/cpu/s390/s390.ad
index 4235d00..e5d6acc 100644
--- a/src/hotspot/cpu/s390/s390.ad
+++ b/src/hotspot/cpu/s390/s390.ad
@@ -2456,9 +2456,6 @@
// Definition of frame structure and management information.
frame %{
- // What direction does stack grow in (assumed to be same for native & Java).
- stack_direction(TOWARDS_LOW);
-
// These two registers define part of the calling convention between
// compiled code and the interpreter.
diff --git a/src/hotspot/cpu/x86/x86_32.ad b/src/hotspot/cpu/x86/x86_32.ad
index 4fccb02..98f676e 100644
--- a/src/hotspot/cpu/x86/x86_32.ad
+++ b/src/hotspot/cpu/x86/x86_32.ad
@@ -3191,9 +3191,6 @@
// the region from SP to FP meets the minimum stack alignment.
frame %{
- // What direction does stack grow in (assumed to be same for C & Java)
- stack_direction(TOWARDS_LOW);
-
// These three registers define part of the calling convention
// between compiled code and the interpreter.
inline_cache_reg(EAX); // Inline Cache Register
diff --git a/src/hotspot/cpu/x86/x86_64.ad b/src/hotspot/cpu/x86/x86_64.ad
index f26f6fa..0d22933 100644
--- a/src/hotspot/cpu/x86/x86_64.ad
+++ b/src/hotspot/cpu/x86/x86_64.ad
@@ -2740,9 +2740,6 @@
frame
%{
- // What direction does stack grow in (assumed to be same for C & Java)
- stack_direction(TOWARDS_LOW);
-
// These three registers define part of the calling convention
// between compiled code and the interpreter.
inline_cache_reg(RAX); // Inline Cache Register
diff --git a/src/hotspot/share/adlc/adlparse.cpp b/src/hotspot/share/adlc/adlparse.cpp
index 547b378..82d24da 100644
--- a/src/hotspot/share/adlc/adlparse.cpp
+++ b/src/hotspot/share/adlc/adlparse.cpp
@@ -985,9 +985,6 @@
parse_err(SYNERR, "missing identifier inside frame block.\n");
return;
}
- if (strcmp(token,"stack_direction")==0) {
- stack_dir_parse(frame);
- }
if (strcmp(token,"sync_stack_slots")==0) {
sync_stack_slots_parse(frame);
}
@@ -1109,21 +1106,6 @@
// skipws();
}
-//------------------------------stack_dir_parse--------------------------------
-void ADLParser::stack_dir_parse(FrameForm *frame) {
- char *direction = parse_one_arg("stack direction entry");
- if (strcmp(direction, "TOWARDS_LOW") == 0) {
- frame->_direction = false;
- }
- else if (strcmp(direction, "TOWARDS_HIGH") == 0) {
- frame->_direction = true;
- }
- else {
- parse_err(SYNERR, "invalid value inside stack direction entry.\n");
- return;
- }
-}
-
//------------------------------sync_stack_slots_parse-------------------------
void ADLParser::sync_stack_slots_parse(FrameForm *frame) {
// Assign value into frame form
diff --git a/src/hotspot/share/adlc/adlparse.hpp b/src/hotspot/share/adlc/adlparse.hpp
index b1d27bd..a2ec2d7 100644
--- a/src/hotspot/share/adlc/adlparse.hpp
+++ b/src/hotspot/share/adlc/adlparse.hpp
@@ -110,7 +110,6 @@
void enc_class_parse_block(EncClass* encoding, char* ec_name);
// Parse the components of the frame section
- void stack_dir_parse(FrameForm *frame); // Parse the stack direction entry
void sync_stack_slots_parse(FrameForm *frame);
void frame_pointer_parse(FrameForm *frame, bool native);
void interpreter_frame_pointer_parse(FrameForm *frame, bool native);
diff --git a/src/hotspot/share/adlc/formsopt.hpp b/src/hotspot/share/adlc/formsopt.hpp
index 7051c89..cc2434a 100644
--- a/src/hotspot/share/adlc/formsopt.hpp
+++ b/src/hotspot/share/adlc/formsopt.hpp
@@ -334,7 +334,6 @@
public:
// Public Data
- bool _direction; // Direction of stack growth
char *_sync_stack_slots;
char *_inline_cache_reg;
char *_interpreter_method_oop_reg;
diff --git a/src/hotspot/share/adlc/output_c.cpp b/src/hotspot/share/adlc/output_c.cpp
index 5c4dafb..8ccab58 100644
--- a/src/hotspot/share/adlc/output_c.cpp
+++ b/src/hotspot/share/adlc/output_c.cpp
@@ -4143,9 +4143,6 @@
// Output the methods to Matcher which specify frame behavior
void ArchDesc::buildFrameMethods(FILE *fp_cpp) {
fprintf(fp_cpp,"\n\n");
- // Stack Direction
- fprintf(fp_cpp,"bool Matcher::stack_direction() const { return %s; }\n\n",
- _frame->_direction ? "true" : "false");
// Sync Stack Slots
fprintf(fp_cpp,"int Compile::sync_stack_slots() const { return %s; }\n\n",
_frame->_sync_stack_slots);
diff --git a/src/hotspot/share/opto/matcher.hpp b/src/hotspot/share/opto/matcher.hpp
index c55b6d2..9038497 100644
--- a/src/hotspot/share/opto/matcher.hpp
+++ b/src/hotspot/share/opto/matcher.hpp
@@ -358,9 +358,6 @@
// These calls are all generated by the ADLC
- // TRUE - grows up, FALSE - grows down (Intel)
- virtual bool stack_direction() const;
-
// Java-Java calling convention
// (what you use when Java calls Java)
