commit b7f7f038529135a5c21234ae89e4b87a1c56854a
author Mathias Agopian <mathias@google.com> Mon Nov 09 20:15:50 2009 -0800
committer Mathias Agopian <mathias@google.com> Mon Nov 09 20:15:50 2009 -0800
tree 897f08a27b3cfa62841fb42f4ece4be982adb56f
parent ba36d4fa33072ef14183365fffd289762c26905e

enable mdp debugging on error, also check for invalid inputs

libcopybit/copybit.cpp

diff --git a/libcopybit/copybit.cpp b/libcopybit/copybit.cpp
index 367941b..ba8531b 100644
--- a/libcopybit/copybit.cpp
+++ b/libcopybit/copybit.cpp
@@ -36,7 +36,7 @@
 
 #include "gralloc_priv.h"
 
-#define DEBUG_MDP_ERRORS 0
+#define DEBUG_MDP_ERRORS 1
 
 /******************************************************************************/
 
@@ -359,7 +359,13 @@
                     return -EINVAL;
             }
         }
-        
+
+        if (src_rect->l < 0 || src_rect->r > src->w ||
+            src_rect->t < 0 || src_rect->b > src->h) {
+            // this is always invalid
+            return -EINVAL;
+        }
+
         const uint32_t maxCount = sizeof(list.req)/sizeof(list.req[0]);
         const struct copybit_rect_t bounds = { 0, 0, dst->w, dst->h };
         struct copybit_rect_t clip;