| commit | 3648ac967a6707767ef2df1cb9aa93b1a1a83f2d | [log] [tgz] |
|---|---|---|
| author | Eric Jeong <ericjeong@google.com> | Fri Sep 18 12:14:54 2020 -0700 |
| committer | Eric Jeong <ericjeong@google.com> | Fri Sep 18 16:13:41 2020 -0700 |
| tree | 1bf2c4d41a7ccd98f474c5baa2baab9ac61ca3f6 | |
| parent | 294b32dd3fb7886065172a1ff5e5cf5cd943f761 [diff] |
Return immediately when prop is not found - when VHAL prop is not supported, getPropConfigs calls hidl callback with INVALID_ARG and has to return. - otherwise, there will be two callbacks invoked from VHAL. Bug: 168834308 Test: seahawk should boot up Change-Id: I41f5ddf26b9ba70221d59bae10d7ca9a2133a9eb Merged-In: I41f5ddf26b9ba70221d59bae10d7ca9a2133a9eb (cherry picked from commit 26abceefbe8f2d8bb11b684e9c3bdc5dc68ab581)
diff --git a/automotive/vehicle/2.0/default/common/src/VehicleHalManager.cpp b/automotive/vehicle/2.0/default/common/src/VehicleHalManager.cpp index b09e9bf..dc5d3d3 100644 --- a/automotive/vehicle/2.0/default/common/src/VehicleHalManager.cpp +++ b/automotive/vehicle/2.0/default/common/src/VehicleHalManager.cpp
@@ -78,6 +78,7 @@ } else { ALOGW("Requested config for undefined property: 0x%x", prop); _hidl_cb(StatusCode::INVALID_ARG, hidl_vec<VehiclePropConfig>()); + return Void(); } }