/*
 INTEL CONFIDENTIAL
 Copyright 2009 Intel Corporation All Rights Reserved.
 The source code contained or described herein and all documents related to the source code ("Material") are owned by Intel Corporation or its suppliers or licensors. Title to the Material remains with Intel Corporation or its suppliers and licensors. The Material contains trade secrets and proprietary and confidential information of Intel or its suppliers and licensors. The Material is protected by worldwide copyright and trade secret laws and treaty provisions. No part of the Material may be used, copied, reproduced, modified, published, uploaded, posted, transmitted, distributed, or disclosed in any way without Intel’s prior express written permission.

 No license under any patent, copyright, trade secret or other intellectual property right is granted to or conferred upon you by disclosure or delivery of the Materials, either expressly, by implication, inducement, estoppel or otherwise. Any license under such intellectual property rights must be express and approved by Intel in writing.
 */

#include <math.h>
#ifndef ANDROID
#include <va/va_x11.h>
#endif

#include "mixvideolog.h"
#include "mixvideoformat_h264.h"
#include "mixvideoconfigparamsdec_h264.h"

#ifdef MIX_LOG_ENABLE
static int mix_video_h264_counter = 0;
#endif /* MIX_LOG_ENABLE */

#define HACK_DPB
#ifdef HACK_DPB
static inline MIX_RESULT mix_videofmt_h264_hack_dpb( MixVideoFormat *mix, vbp_picture_data_h264* pic_data);
#endif


// Local Help Funcs


/* The parent class. The pointer will be saved
 * in this class's initialization. The pointer
 * can be used for chaining method call if needed.
 */
MixVideoFormat_H264::MixVideoFormat_H264()
        :dpb_surface_table(NULL)
#ifdef DECODER_ROBUSTNESS
        ,last_decoded_frame(NULL)
#endif
{}

MixVideoFormat_H264::~MixVideoFormat_H264() {
    int32 pret = VBP_OK;
    /* clean up here. */
    //surfacepool is deallocated by parent
    //inputbufqueue is deallocated by parent
    //parent calls vaDestroyConfig, vaDestroyContext and vaDestroySurfaces

    if (this->dpb_surface_table) {
        //Free the DPB surface table
        //First remove all the entries (frames will be unrefed)
        j_hash_table_remove_all(this->dpb_surface_table);
        //Then unref the table
        j_hash_table_unref(this->dpb_surface_table);
        this->dpb_surface_table = NULL;
    }

    Lock();
    this->initialized = TRUE;
    this->parse_in_progress = FALSE;

    //Close the parser
    pret = vbp_close(this->parser_handle);
    this->parser_handle = NULL;
    if (pret != VBP_OK) {
        LOG_E( "Error closing parser\n");
    }
    Unlock();
}

MIX_RESULT MixVideoFormat_H264::Initialize(
    MixVideoConfigParamsDec * config_params,
    MixFrameManager * frame_mgr,
    MixBufferPool * input_buf_pool,
    MixSurfacePool ** surface_pool,
    VADisplay va_display) {

    uint32 pret = 0;
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    enum _vbp_parser_type ptype = VBP_H264;
    vbp_data_h264 *data = NULL;
    MixIOVec *header = NULL;

    MixVideoConfigParamsDecH264 *config_params_h264 = NULL;
    bool va_setup_flag = FALSE;

    if (config_params == NULL || frame_mgr == NULL ||
            input_buf_pool == NULL || va_display == NULL) {
        LOG_E( "NUll pointer passed in\n");
        return MIX_RESULT_NULL_PTR;
    }

    LOG_V( "Begin\n");
    // chain up parent method
    MixVideoFormat::Initialize(config_params, frame_mgr, input_buf_pool,
                               surface_pool, va_display);

    /* Chainup parent method. */
    LOG_V( "Locking\n");
    //From now on, we exit this function through cleanup:
    Lock();

    this->surfacepool = mix_surfacepool_new();
    *surface_pool = this->surfacepool;

    if (NULL == this->surfacepool) {
        ret = MIX_RESULT_NO_MEMORY;
        LOG_E( "parent->surfacepool == NULL.\n");
        goto CLEAN_UP;
    }

    //Create our table of Decoded Picture Buffer "in use" surfaces
    this->dpb_surface_table = j_hash_table_new_full(NULL, NULL,
                              mix_videofmt_h264_destroy_DPB_key, mix_videofmt_h264_destroy_DPB_value);

    if (NULL == this->dpb_surface_table) {
        ret = MIX_RESULT_NO_MEMORY;
        LOG_E( "Error allocating dbp surface table\n");
        goto CLEAN_UP;
    }

    ret = mix_videoconfigparamsdec_get_extra_surface_allocation(
              config_params, &(this->extra_surfaces));

    if (ret != MIX_RESULT_SUCCESS) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Cannot get extra surface allocation setting\n");
        goto CLEAN_UP;
    }

    ret = mix_videoconfigparamsdec_get_error_concealment(
              config_params,
              &this->error_concealment);

    if (ret != MIX_RESULT_SUCCESS)
    {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Cannot get error_concealment flag\n");
        goto CLEAN_UP;
    }

    config_params_h264 = MIX_VIDEOCONFIGPARAMSDEC_H264(config_params);
    ret = mix_videoconfigparamsenc_h264_get_va_setup_flag(config_params_h264, &va_setup_flag);
    if (ret != MIX_RESULT_SUCCESS)
    {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Failed to get va_setup_flag\n");
        return ret;
    }

    LOG_V("va_setup_flag = %d\n", va_setup_flag);

    LOG_V( "Before vbp_open\n");
    //Load the bitstream parser
    pret = vbp_open(ptype, &(this->parser_handle));
    LOG_V( "After vbp_open\n");

    if (VBP_OK != pret) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Error opening parser\n");
        goto CLEAN_UP;
    }
    LOG_V( "Opened parser\n");

    if(va_setup_flag) {
        LOG_V("calling to mix_videofmt_h264_initialize_va(mix, NULL)\n");
        ret = _initialize_va( NULL);
        LOG_V("ret = 0x%x\n", ret);
        if (ret != MIX_RESULT_SUCCESS)
        {
            LOG_E( "Error initializing va. \n");
        }
        goto CLEAN_UP;
    }

    ret = mix_videoconfigparamsdec_get_header(config_params, &header);

    if ((MIX_RESULT_SUCCESS != ret) || (NULL == header)) {
        // Delay initializing VA if codec configuration data is not ready, but don't return an error.
        ret = MIX_RESULT_SUCCESS;
        LOG_W( "Codec data is not available in the configuration parameter.\n");
        goto CLEAN_UP;
    }

    LOG_V( "Calling parse on header data, handle %d\n", (int)(this->parser_handle));

    pret = vbp_parse(this->parser_handle, header->data, header->data_size, TRUE);

    if (VBP_OK != pret) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Error parsing header data\n");
        goto CLEAN_UP;
    }

    LOG_V( "Parsed header\n");

    //Get the header data and save
    pret = vbp_query(this->parser_handle, (void **)&data);

    if (VBP_OK != pret) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Error reading parsed header data\n");
        goto CLEAN_UP;
    }

    LOG_V( "Queried parser for header data\n");

    _update_config_params(data);

    ret = _initialize_va(data);
    if (MIX_RESULT_SUCCESS != ret) {
        LOG_E( "Error initializing va. \n");
        goto CLEAN_UP;
    }

CLEAN_UP:
    if (MIX_RESULT_SUCCESS != ret) {
        pret = vbp_close(this->parser_handle);
        this->parser_handle = NULL;
        this->initialized = FALSE;
    } else {
        this->initialized = TRUE;
    }
    if (NULL != header) {
        if (NULL != header->data)
            free(header->data);
        free(header);
        header = NULL;
    }
    LOG_V( "Unlocking\n");
    Unlock();
    return ret;

}

MIX_RESULT MixVideoFormat_H264::Decode(
    MixBuffer * bufin[], int bufincnt,
    MixVideoDecodeParams * decode_params) {

    int i = 0;
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    uint64 ts = 0;
    bool discontinuity = FALSE;

    LOG_V( "Begin\n");

    if (NULL == bufin || NULL == decode_params || 0 == bufincnt) {
        LOG_E( "NUll pointer passed in\n");
        return MIX_RESULT_NULL_PTR;
    }

    /* Chainup parent method.
    	We are not chaining up to parent method for now.
    */
#if 0
    MixVideoFormat::Decode(bufin, bufincnt, decode_params);
#endif

    ret = mix_videodecodeparams_get_timestamp(decode_params, &ts);
    if (ret != MIX_RESULT_SUCCESS) {
        // never happen
        return MIX_RESULT_FAIL;
    }

    ret = mix_videodecodeparams_get_discontinuity(decode_params, &discontinuity);
    if (ret != MIX_RESULT_SUCCESS) {
        // never happen
        return MIX_RESULT_FAIL;
    }

    decode_params->new_sequence = FALSE;

    //From now on, we exit this function through cleanup:
    LOG_V( "Locking\n");
    Lock();

    LOG_V( "Starting current frame %d, timestamp %"UINT64_FORMAT"\n", mix_video_h264_counter++, ts);

    for (i = 0; i < bufincnt; i++) {
        LOG_V( "Decoding a buf %x, size %d\n", (uint)bufin[i]->data, bufin[i]->size);
        // decode a buffer at a time
        ret = _decode_a_buffer(
                  bufin[i],
                  ts,
                  discontinuity,
                  decode_params,
                  (i == bufincnt-1 ? decode_params->complete_frame : 0));

        if (MIX_RESULT_SUCCESS != ret) {
            LOG_E("mix_videofmt_h264_decode_a_buffer failed.\n");
            goto CLEAN_UP;
        }
    }

CLEAN_UP:
    LOG_V( "Unlocking\n");
    Unlock();
    LOG_V( "End\n");
    return ret;
}

MIX_RESULT MixVideoFormat_H264::Flush() {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    LOG_V( "Begin\n");
    uint32 pret = 0;
    /* Chainup parent method.
    	We are not chaining up to parent method for now.
     */
#if 0
    MixVideoFormat::Flush();
#endif
    Lock();
    // drop any decode-pending picture, and ignore return value
    _decode_end(TRUE);

    //Clear parse_in_progress flag and current timestamp
    this->parse_in_progress = FALSE;
    this->discontinuity_frame_in_progress = FALSE;
    this->current_timestamp = (uint64)-1;

    //Clear the DPB surface table
    j_hash_table_remove_all(this->dpb_surface_table);

    //Call parser flush
    pret = vbp_flush(this->parser_handle);
    if (VBP_OK != pret)
        ret = MIX_RESULT_FAIL;

    Unlock();
    LOG_V( "End\n");
    return ret;

}

MIX_RESULT MixVideoFormat_H264::EndOfStream() {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    LOG_V( "Begin\n");
    /* Chainup parent method.
    	We are not chaining up to parent method for now.
     */
#if 0
    if (parent_class->eos) {
        return parent_class->eos(mix, msg);
    }
#endif
    Lock();
    // finished decoding the pending frame
    _decode_end(FALSE);
    Unlock();
    //Call Frame Manager with _eos()
    ret = mix_framemanager_eos(this->framemgr);
    LOG_V( "End\n");
    return ret;
}


MixVideoFormat_H264 * mix_videoformat_h264_new(void) {
    return new MixVideoFormat_H264();
}


MixVideoFormat_H264 *mix_videoformat_h264_ref(MixVideoFormat_H264 * mix) {
    if (NULL != mix)
        mix->Ref();
    return mix;
}

MixVideoFormat_H264 *mix_videoformat_h264_unref(MixVideoFormat_H264 *mix) {
    if (NULL != mix)
        return MIX_VIDEOFORMAT_H264(mix->Unref());
    else
        return mix;
}

MIX_RESULT MixVideoFormat_H264::_update_config_params(vbp_data_h264 *data) {
    if (0 == this->picture_width || 0 == this->picture_height || data->new_sps) 	{
        this->picture_width =
            (data->pic_data[0].pic_parms->picture_width_in_mbs_minus1 + 1) * 16;
        this->picture_height =
            (data->pic_data[0].pic_parms->picture_height_in_mbs_minus1 + 1) * 16;

        mix_videoconfigparamsdec_set_picture_res(
            this->config_params, this->picture_width, this->picture_height);
    }

    // video_range has default value of 0.
    mix_videoconfigparamsdec_set_video_range(this->config_params,
            data->codec_data->video_full_range_flag);

    uint8 color_matrix;
    switch (data->codec_data->matrix_coefficients) {
    case 1:
        color_matrix = VA_SRC_BT709;
        break;
        // ITU-R Recommendation BT.470-6 System B, G (MP4), same as
        // SMPTE 170M/BT601
    case 5:
    case 6:
        color_matrix = VA_SRC_BT601;
        break;
    default:
        // unknown color matrix, set to 0 so color space flag will not be set.
        color_matrix = 0;
        break;
    }
    mix_videoconfigparamsdec_set_color_matrix(this->config_params, color_matrix);
    mix_videoconfigparamsdec_set_pixel_aspect_ratio(
        this->config_params,
        data->codec_data->sar_width,
        data->codec_data->sar_height);
    mix_videoconfigparamsdec_set_bit_rate(
        this->config_params, data->codec_data->bit_rate);

    LOG_V("crop_left = %d crop_right = %d crop_top = %d crop_bottom = %d\n",
          data->codec_data->crop_left, data->codec_data->crop_right,
          data->codec_data->crop_top, data->codec_data->crop_bottom);

    mix_videoconfigparamsdec_set_cropping_info(
        this->config_params,
        data->codec_data->crop_left,
        data->codec_data->crop_right,
        data->codec_data->crop_top,
        data->codec_data->crop_bottom);
    return MIX_RESULT_SUCCESS;
}


MIX_RESULT MixVideoFormat_H264::_initialize_va(vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    VAStatus vret = VA_STATUS_SUCCESS;
    VAConfigAttrib attrib;
    if (this->va_initialized) {
        LOG_W("va already initialized.\n");
        return MIX_RESULT_SUCCESS;
    }
    LOG_V( "Begin\n");
    //We are requesting RT attributes
    attrib.type = VAConfigAttribRTFormat;
    attrib.value = VA_RT_FORMAT_YUV420;

    //Initialize and save the VA config ID
#ifdef ANDROID
    if((this->error_concealment == TRUE) && (data == NULL || (data != NULL && ((data->codec_data->profile_idc == 66) || (data->codec_data->constraint_set0_flag == 1)) &&
            (data->codec_data->constraint_set1_flag == 1))))
    {
        //it is constrained baseline profile according to subclause A.2.1.1 in H.264 Spec v200903
        vret = vaCreateConfig(
                   this->va_display,
                   VAProfileH264ConstrainedBaseline,
                   VAEntrypointVLD,
                   &attrib,
                   1,
                   &(this->va_config));
    }
    else
    {
#endif
        //We use high profile for all kinds of H.264 profiles (baseline, main and high) except for constrained baseline
        vret = vaCreateConfig(
                   this->va_display,
                   VAProfileH264High,
                   VAEntrypointVLD,
                   &attrib,
                   1,
                   &(this->va_config));
#ifdef ANDROID
    }
#endif
    if (VA_STATUS_SUCCESS != vret) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E("vaCreateConfig failed\n");
        return ret;
    }

#ifdef MIX_LOG_ENABLE
    if(data) {
        LOG_V( "Codec data says num_ref_frames is %d\n", data->codec_data->num_ref_frames);
    }
#endif

    // handle both frame and field coding for interlaced content
    int num_ref_pictures = 0;
    if(data) {
        num_ref_pictures = data->codec_data->num_ref_frames;
    }

    //Adding 1 to work around VBLANK issue, and another 1 to compensate cached frame that
    // will not start decoding until a new frame is received.
    this->va_num_surfaces = 1 + 1 + this->extra_surfaces +
                            (((num_ref_pictures + 3) < MIX_VIDEO_H264_SURFACE_NUM) ? (num_ref_pictures + 3) : MIX_VIDEO_H264_SURFACE_NUM);

    this->va_surfaces =
        reinterpret_cast<VASurfaceID*>(malloc(sizeof(VASurfaceID)*this->va_num_surfaces));
    if (NULL == this->va_surfaces) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E( "parent->va_surfaces == NULL. \n");
        return ret;
    }

#ifdef MIX_LOG_ENABLE
    if(data) {
        LOG_V( "Codec data says picture size is %d x %d\n",
               (data->pic_data[0].pic_parms->picture_width_in_mbs_minus1 + 1) * 16,
               (data->pic_data[0].pic_parms->picture_height_in_mbs_minus1 + 1) * 16);
        LOG_V( "getcaps says picture size is %d x %d\n", this->picture_width, this->picture_height);
    }
#endif

    vret = vaCreateSurfaces(
               this->va_display,
               this->picture_width,
               this->picture_height,
               VA_RT_FORMAT_YUV420,
               this->va_num_surfaces,
               this->va_surfaces);

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E( "Error allocating surfaces\n");
        return ret;
    }

    LOG_V( "Created %d libva surfaces\n", this->va_num_surfaces);

    //Initialize the surface pool
    ret = mix_surfacepool_initialize(
              this->surfacepool,
              this->va_surfaces,
              this->va_num_surfaces,
              this->va_display);

    switch (ret) {
    case MIX_RESULT_SUCCESS:
        break;
    case MIX_RESULT_ALREADY_INIT:  //This case is for future use when we can be  initialized multiple times.  It is to detect when we have not been reset before re-initializing.
    default:
        ret = MIX_RESULT_ALREADY_INIT;
        LOG_E( "Error init surface pool\n");
        return ret;
        break;
    }
#if 0 // NOTE: We don't use the value in frame manager, comment out the following lines

    if (data->codec_data->pic_order_cnt_type == 0) {
        int max = (int)pow(2, data->codec_data->log2_max_pic_order_cnt_lsb_minus4 + 4);
        mix_framemanager_set_max_picture_number(this->framemgr, max);
    }
#endif

    //Initialize and save the VA context ID
    //Note: VA_PROGRESSIVE libva flag is only relevant to MPEG2
    vret = vaCreateContext(
               this->va_display,
               this->va_config,
               this->picture_width,
               this->picture_height,
               0,  // no flag set
               this->va_surfaces,
               this->va_num_surfaces,
               &(this->va_context));

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E( "Error initializing video driver\n");
        return ret;
    }

    this->va_initialized = TRUE;

    return ret;
}


MIX_RESULT MixVideoFormat_H264::_handle_new_sequence(vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    LOG_V("new sequence is received.\n");

    // original picture resolution
    uint32 width = this->picture_width;
    uint32 height = this->picture_height;

    _update_config_params(data);

    if (width != this->picture_width || height != this->picture_height) {
        // flush frame manager only if resolution is changed.
        ret = mix_framemanager_flush(this->framemgr);
    }
    // TO DO:  re-initialize VA
    return ret;
}


MIX_RESULT MixVideoFormat_H264::_update_ref_pic_list(
    VAPictureParameterBufferH264* picture_params,
    VASliceParameterBufferH264* slice_params) {
    //Do slice parameters
    //First patch up the List0 and List1 surface IDs
    uint32 j = 0;
    uint poc = 0;
    void* video_frame = NULL;
    MIX_RESULT ret = MIX_RESULT_SUCCESS;

    for (; j <= slice_params->num_ref_idx_l0_active_minus1; j++) {
        if (!(slice_params->RefPicList0[j].flags & VA_PICTURE_H264_INVALID)) {
            poc = mix_videofmt_h264_get_poc(&(slice_params->RefPicList0[j]));
            video_frame = j_hash_table_lookup(this->dpb_surface_table, (void*)poc);
            if (video_frame == NULL) {
                LOG_E("unable to find surface of picture %d (current picture %d).",
                      poc, mix_videofmt_h264_get_poc(&(picture_params->CurrPic)));
                ret = MIX_RESULT_DROPFRAME;  //return non-fatal error
                return ret;
            } else {
                slice_params->RefPicList0[j].picture_id =
                    ((MixVideoFrame *)video_frame)->frame_id;
            }
        }
    }

    if ((slice_params->slice_type == 1) || (slice_params->slice_type == 6)) {
        for (j = 0; j <= slice_params->num_ref_idx_l1_active_minus1; j++) {
            if (!(slice_params->RefPicList1[j].flags & VA_PICTURE_H264_INVALID)) {
                poc = mix_videofmt_h264_get_poc(&(slice_params->RefPicList1[j]));
                video_frame = j_hash_table_lookup(this->dpb_surface_table, (void*)poc);
                if (video_frame == NULL) {
                    LOG_E("unable to find surface of picture %d (current picture %d).",
                          poc, mix_videofmt_h264_get_poc(&(picture_params->CurrPic)));
                    ret = MIX_RESULT_DROPFRAME;  //return non-fatal error
                    return ret;
                } else {
                    slice_params->RefPicList1[j].picture_id =
                        ((MixVideoFrame *)video_frame)->frame_id;
                }
            }
        }
    }
    return ret;
}

MIX_RESULT MixVideoFormat_H264::_decode_a_slice(
    vbp_data_h264 *data, int picture_index, int slice_index) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    VAStatus vret = VA_STATUS_SUCCESS;
    VADisplay vadisplay = NULL;
    VAContextID vacontext;
    uint buffer_id_cnt = 0;

    // maximum 4 buffers to render a slice: picture parameter, IQMatrix, slice parameter, slice data
    VABufferID buffer_ids[4];

    LOG_V( "Begin\n");
    //MixVideoFormat_H264 *self = MIX_VIDEOFORMAT_H264(mix);
    vbp_picture_data_h264* pic_data = &(data->pic_data[picture_index]);
    vbp_slice_data_h264* slice_data = &(pic_data->slc_data[slice_index]);
    VAPictureParameterBufferH264 *pic_params = pic_data->pic_parms;
    VASliceParameterBufferH264* slice_params = &(slice_data->slc_parms);
    vadisplay = this->va_display;
    vacontext = this->va_context;

#ifdef DECODER_ROBUSTNESS
    if ((slice_params->first_mb_in_slice == 0) || (!this->end_picture_pending))
#else
    if (slice_params->first_mb_in_slice == 0)
#endif
    {
        // this is the first slice of the picture
        if (this->end_picture_pending) {
            // interlace content, decoding the first field
            vret = vaEndPicture(vadisplay, vacontext);
            if (vret != VA_STATUS_SUCCESS) {
                ret = MIX_RESULT_FAIL;
                LOG_E("vaEndPicture failed.\n");
                LOG_V( "End\n");
                return ret;
            }
            // for interlace content, top field may be valid only after the second field is parsed
            mix_videoframe_set_displayorder(this->video_frame, pic_params->CurrPic.TopFieldOrderCnt);
        }

        ulong surface = 0;
        LOG_V("mix->video_frame = 0x%x\n", (unsigned)this->video_frame);

        //Get our surface ID from the frame object
        ret = mix_videoframe_get_frame_id(this->video_frame, &surface);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_E( "Error getting surface ID from frame object\n");
            LOG_V( "End\n");
            return ret;
        }

#ifdef DECODER_ROBUSTNESS
        LOG_V( "Updating DPB for libva\n");
        //Now handle the reference frames and surface IDs for DPB and current frame
        _handle_ref_frames(pic_params, this->video_frame);
#ifdef HACK_DPB
        //We have to provide a hacked DPB rather than complete DPB for libva as workaround
        ret = mix_videofmt_h264_hack_dpb(this, pic_data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_E( "Error reference frame not found\n");
            //Need to remove the frame we inserted in _handle_ref_frames above, since we are not going to decode it
            _cleanup_ref_frame(pic_params, this->video_frame);
            LOG_V( "End\n");
            return ret;
        }
#endif
        LOG_V( "Calling vaBeginPicture\n");
        //Now we can begin the picture
        vret = vaBeginPicture(vadisplay, vacontext, surface);
        if (vret != VA_STATUS_SUCCESS) {
            ret = MIX_RESULT_FAIL;
            LOG_E( "Video driver returned error from vaBeginPicture\n");
            LOG_V( "End\n");
            return ret;
        }
        // vaBeginPicture needs a matching vaEndPicture
        this->end_picture_pending = TRUE;
#else
        LOG_V( "Calling vaBeginPicture\n");

        //Now we can begin the picture
        vret = vaBeginPicture(vadisplay, vacontext, surface);
        if (vret != VA_STATUS_SUCCESS) {
            ret = MIX_RESULT_FAIL;
            LOG_E( "Video driver returned error from vaBeginPicture\n");
            LOG_V( "End\n");
            return ret;
        }
        // vaBeginPicture needs a matching vaEndPicture
        this->end_picture_pending = TRUE;
        LOG_V( "Updating DPB for libva\n");
        //Now handle the reference frames and surface IDs for DPB and current frame
        _handle_ref_frames(pic_params, this->video_frame);

#ifdef HACK_DPB
        //We have to provide a hacked DPB rather than complete DPB for libva as workaround
        ret = mix_videofmt_h264_hack_dpb(this, pic_data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_E( "Error reference frame not found\n");
            LOG_V( "End\n");
            return ret;
        }
#endif

#endif
        //Libva buffer set up
        LOG_V( "Creating libva picture parameter buffer\n");
        LOG_V( "picture parameter buffer shows num_ref_frames is %d\n", pic_params->num_ref_frames);
        //First the picture parameter buffer
        vret = vaCreateBuffer(
                   vadisplay,
                   vacontext,
                   VAPictureParameterBufferType,
                   sizeof(VAPictureParameterBufferH264),
                   1,
                   pic_params,
                   &buffer_ids[buffer_id_cnt]);

        if (vret != VA_STATUS_SUCCESS) {
            ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
            LOG_E( "Video driver returned error from vaCreateBuffer\n");
            LOG_V( "End\n");
            return ret;
        }

        buffer_id_cnt++;
        LOG_V( "Creating libva IQMatrix buffer\n");

        //Then the IQ matrix buffer
        vret = vaCreateBuffer(
                   vadisplay,
                   vacontext,
                   VAIQMatrixBufferType,
                   sizeof(VAIQMatrixBufferH264),
                   1,
                   data->IQ_matrix_buf,
                   &buffer_ids[buffer_id_cnt]);

        if (vret != VA_STATUS_SUCCESS) {
            ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
            LOG_E( "Video driver returned error from vaCreateBuffer\n");
            LOG_V( "End\n");
            return ret;
        }
        buffer_id_cnt++;
    }

#ifndef DECODER_ROBUSTNESS
    if (!this->end_picture_pending) {
        LOG_E("first slice is lost??????????\n");
        ret = MIX_RESULT_DROPFRAME;
        LOG_V( "End\n");
        return ret;

    }
#endif

    //Now for slices

    ret = _update_ref_pic_list(pic_params, slice_params);
    if (ret != MIX_RESULT_SUCCESS) {
        LOG_E("mix_videofmt_h264_update_ref_pic_list failed.\n");
        LOG_V( "End\n");
        return ret;
    }

    LOG_V( "Creating libva slice parameter buffer\n");

    vret = vaCreateBuffer(
               vadisplay,
               vacontext,
               VASliceParameterBufferType,
               sizeof(VASliceParameterBufferH264),
               1,
               slice_params,
               &buffer_ids[buffer_id_cnt]);

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E( "Video driver returned error from vaCreateBuffer\n");
        LOG_V( "End\n");
        return ret;
    }

    buffer_id_cnt++;

    //Do slice data

    //slice data buffer pointer
    //Note that this is the original data buffer ptr;
    // offset to the actual slice data is provided in
    // slice_data_offset in VASliceParameterBufferH264

    LOG_V( "Creating libva slice data buffer, using slice address %x, with offset %d and size %u\n",
           (uint)slice_data->buffer_addr, slice_params->slice_data_offset, slice_data->slice_size);

    vret = vaCreateBuffer(
               vadisplay,
               vacontext,
               VASliceDataBufferType,
               slice_data->slice_size, //size
               1,        //num_elements
               slice_data->buffer_addr + slice_data->slice_offset,
               &buffer_ids[buffer_id_cnt]);

    buffer_id_cnt++;

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_NO_MEMORY; // MIX_RESULT_FAIL;
        LOG_E( "Video driver returned error from vaCreateBuffer\n");
        LOG_V( "End\n");
        return ret;

    }


    LOG_V( "Calling vaRenderPicture\n");

    //Render the picture
    vret = vaRenderPicture(
               vadisplay,
               vacontext,
               buffer_ids,
               buffer_id_cnt);

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Video driver returned error from vaRenderPicture\n");
        LOG_V( "End\n");
        return ret;
    }

    LOG_V( "End\n");
    return ret;

}

MIX_RESULT MixVideoFormat_H264::_decode_end(bool drop_picture) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    VAStatus vret = VA_STATUS_SUCCESS;

#ifdef DECODER_ROBUSTNESS
    //MixVideoFormat_H264 *self = MIX_VIDEOFORMAT_H264(mix);
#else
    //MixVideoFormat_H264 *self = MIX_VIDEOFORMAT_H264(mix);
#endif

    LOG_V("Begin\n");
    if (!this->end_picture_pending) {
        if (this->video_frame) {
            ret = MIX_RESULT_FAIL;
            LOG_E("Unexpected: video_frame is not unreferenced.\n");
        }
        goto CLEAN_UP;
    }

    if (this->video_frame == NULL) {
        ret = MIX_RESULT_FAIL;
        LOG_E("Unexpected: video_frame has been unreferenced.\n");
        goto CLEAN_UP;
    }

    LOG_V( "Calling vaEndPicture\n");
    vret = vaEndPicture(this->va_display, this->va_context);

    if (vret != VA_STATUS_SUCCESS) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Video driver returned error from vaEndPicture\n");
        goto CLEAN_UP;
    }

#if 0	/* we don't call vaSyncSurface here, the call is moved to mix_video_render() */

    LOG_V( "Calling vaSyncSurface\n");

    //Decode the picture
    vret = vaSyncSurface(parent->va_display, parent->video_frame->frame_id);

    if (vret != VA_STATUS_SUCCESS)
    {
        ret = MIX_RESULT_FAIL;
        LOG_E( "Video driver returned error from vaSyncSurface\n");
        CLEAN_UP;
    }
#endif

    if (drop_picture) {
        // we are asked to drop this decoded picture
        mix_videoframe_unref(this->video_frame);
        this->video_frame = NULL;
        goto CLEAN_UP;
    }

    LOG_V( "Enqueueing the frame with frame manager, timestamp %"UINT64_FORMAT"\n",
           this->video_frame->timestamp);

#ifdef DECODER_ROBUSTNESS
    if (this->last_decoded_frame)
        mix_videoframe_unref(this->last_decoded_frame);
    this->last_decoded_frame = this->video_frame;
    mix_videoframe_ref(this->last_decoded_frame);
#endif

    //Enqueue the decoded frame using frame manager
    ret = mix_framemanager_enqueue(this->framemgr, this->video_frame);
    if (ret != MIX_RESULT_SUCCESS) {
        LOG_E( "Error enqueuing frame object\n");
        goto CLEAN_UP;
    } else {
        // video frame is passed to frame manager
        this->video_frame = NULL;
        LOG_V("video_frame is assigned to be NULL !\n");
    }

CLEAN_UP:
    if (this->video_frame) {
        /* this always indicates an error */
        mix_videoframe_unref(this->video_frame);
        this->video_frame = NULL;
    }
    this->end_picture_pending = FALSE;
    LOG_V("End\n");
    return ret;
}

MIX_RESULT MixVideoFormat_H264::_decode_continue(vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    uint32 i, j;
    vbp_picture_data_h264* pic_data = NULL;
    LOG_V("Begin\n");
    for (i = 0; i < data->num_pictures; i++) {
        pic_data = &(data->pic_data[i]);
        if (pic_data->pic_parms == NULL) {
            ret = MIX_RESULT_FAIL;
            LOG_E("pic_data->pic_parms is NULL.\n");
            LOG_V("End\n");
            return ret;
        }

        if (pic_data->slc_data == NULL) {
            ret = MIX_RESULT_FAIL;
            LOG_E("pic_data->slc_data is NULL.\n");
            LOG_V("End\n");
            return ret;
        }

        if (pic_data->num_slices == 0) {
            ret = MIX_RESULT_FAIL;
            LOG_E("pic_data->num_slices == 0.\n");
            LOG_V("End\n");
            return ret;
        }

        LOG_V( "num_slices is %d\n", pic_data->num_slices);
        for (j = 0; j < pic_data->num_slices; j++) {
            LOG_V( "Decoding slice %d\n", j);
            ret = _decode_a_slice(data, i, j);
            if (ret != 	MIX_RESULT_SUCCESS) {
                LOG_E( "mix_videofmt_h264_decode_a_slice failed, error =  %#X.", ret);
                LOG_V("End\n");
                return ret;
            }
        }
    }

    LOG_V("End\n");
    return ret;
}


MIX_RESULT MixVideoFormat_H264::_set_frame_type(vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    //Set the picture type (I, B or P frame)
    //For H.264 we use the first encountered slice type for this (check - may need to change later to search all slices for B type)
    MixFrameType frame_type = TYPE_INVALID;
    switch (data->pic_data[0].slc_data[0].slc_parms.slice_type) {
    case 0:
    case 3:
    case 5:
    case 8:
        frame_type = TYPE_P;
        break;
    case 1:
    case 6:
        frame_type = TYPE_B;
        break;
    case 2:
    case 4:
    case 7:
    case 9:
        frame_type = TYPE_I;
        break;
    default:
        break;
    }

    //Do not have to check for B frames after a seek
    //Note:  Demux should seek to IDR (instantaneous decoding refresh) frame, otherwise
    //  DPB will not be correct and frames may come in with invalid references
    //  This will be detected when DPB is checked for valid mapped surfaces and
    //  error returned from there.

    LOG_V( "frame type is %d\n", frame_type);

    //Set the frame type for the frame object (used in reordering by frame manager)
    ret = mix_videoframe_set_frame_type(this->video_frame, frame_type);

    if (ret != MIX_RESULT_SUCCESS) {
        LOG_E( "Error setting frame type on frame\n");
    }
    return ret;
}


MIX_RESULT MixVideoFormat_H264::_set_frame_structure(
    vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    if (data->pic_data[0].pic_parms->CurrPic.flags & VA_PICTURE_H264_TOP_FIELD) {
        mix_videoframe_set_frame_structure(this->video_frame, VA_BOTTOM_FIELD | VA_TOP_FIELD);
    } else {
        mix_videoframe_set_frame_structure(this->video_frame, VA_FRAME_PICTURE);
    }
    return ret;
}


MIX_RESULT MixVideoFormat_H264::_decode_begin(vbp_data_h264 *data) {
    MIX_RESULT ret = MIX_RESULT_SUCCESS;

    //Get a frame from the surface pool
    LOG_V("Begin\n");
    ret = mix_surfacepool_get(this->surfacepool, &(this->video_frame));

    if (ret != MIX_RESULT_SUCCESS) {
        LOG_E( "Error getting frame from surfacepool\n");
        return ret;
    }

    /* the following calls will always succeed */
    // set frame type
    ret = _set_frame_type(data);
    // set frame structure
    ret = _set_frame_structure(data);
    //Set the discontinuity flag
    mix_videoframe_set_discontinuity(this->video_frame, this->discontinuity_frame_in_progress);
    //Set the timestamp
    mix_videoframe_set_timestamp(this->video_frame, this->current_timestamp);
    // Set displayorder
    ret = mix_videoframe_set_displayorder(this->video_frame,
                                          data->pic_data[0].pic_parms->CurrPic.TopFieldOrderCnt);
    if (ret != MIX_RESULT_SUCCESS) {
        LOG_E("Error setting displayorder\n");
        return ret;
    }
    ret = _decode_continue(data);
    LOG_V("End\n");
    return ret;
}

MIX_RESULT MixVideoFormat_H264::_decode_a_buffer(
    MixBuffer * bufin,
    uint64 ts,
    bool discontinuity,
    MixVideoDecodeParams * decode_params,
    bool complete_frame) {
    uint32 pret = 0;
    MIX_RESULT ret = MIX_RESULT_SUCCESS;
    vbp_data_h264 *data = NULL;

    LOG_V( "Begin\n");
    LOG_V( "Calling parse for current frame, parse handle %d\n", (int)this->parser_handle);
    pret = vbp_parse(this->parser_handle,
                     bufin->data,
                     bufin->size,
                     FALSE);

    LOG_V( "Called parse for current frame\n");
    if (pret != VBP_OK) {
        ret = MIX_RESULT_ERROR_PROCESS_STREAM; // MIX_RESULT_DROPFRAME;
        LOG_E( "vbp_parse failed.\n");
        LOG_V("End\n");
        return ret;
    }

    //query for data
    pret = vbp_query(this->parser_handle, (void**)&data);

    if ((pret != VBP_OK) || (data == NULL)) {
        ret = MIX_RESULT_FAIL;
        LOG_E( "vbp_query failed.\n");
        LOG_V("End\n");
        return ret;

    }
    LOG_V( "Called query for current frame\n");

    if (data->has_sps == 0 || data->has_pps == 0) {
        ret = MIX_RESULT_MISSING_CONFIG; // MIX_RESULT_SUCCESS;
        LOG_V("SPS or PPS is not available.\n");
        LOG_V("End\n");
        return ret;

    }

    if (data->new_sps) {
        decode_params->new_sequence = data->new_sps;

        ret = _handle_new_sequence(data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_V("mix_video_h264_handle_new_sequence failed.\n");
            LOG_V("End\n");
            return ret;

        }
    }

    if (this->va_initialized == FALSE) {
        _update_config_params(data);

        LOG_V("try initializing VA...\n");
        ret = _initialize_va(data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_V("mix_videofmt_h264_initialize_va failed.\n");
            LOG_V("End\n");
            return ret;
        }
    }

    // first pic_data always exists, check if any slice is parsed
    if (data->pic_data[0].num_slices == 0) {
        ret = MIX_RESULT_SUCCESS;
        LOG_V("slice is not available.\n");
        LOG_V("End\n");
        return ret;
    }

    uint64 last_ts = this->current_timestamp;
    this->current_timestamp = ts;
    this->discontinuity_frame_in_progress = discontinuity;

    LOG_V("ts = %lli last_ts = %lli\n", ts, last_ts);

    if (last_ts != ts) {
        // finish decoding the last frame
        ret = _decode_end(FALSE);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_V("mix_videofmt_h264_decode_end failed.\n");
            LOG_V("End\n");
            return ret;
        }

        // start decoding a new frame
        ret = _decode_begin(data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_V("mix_videofmt_h264_decode_begin failed.\n");
            LOG_V("End\n");
            return ret;
        }
    } else {
        // parital frame
        LOG_V("partial frame handling...\n");
        ret = _decode_continue(data);
        if (ret != MIX_RESULT_SUCCESS) {
            LOG_V("mix_videofmt_h264_decode_continue failed.\n");
            LOG_V("End\n");
            return ret;
        }
    }
    if (complete_frame)
    {
        // finish decoding current frame
        ret = _decode_end(FALSE);
        if (ret != MIX_RESULT_SUCCESS)
        {
            LOG_V("mix_videofmt_h264_decode_end failed.\n");
            return ret;
        }
    }

    LOG_V("End\n");
    return ret;
}


#ifdef HACK_DPB
static inline MIX_RESULT mix_videofmt_h264_hack_dpb(MixVideoFormat *mix,
        vbp_picture_data_h264* pic_data
                                                   )
{

    bool found = FALSE;
    uint tflags = 0;
    VAPictureParameterBufferH264 *pic_params = pic_data->pic_parms;
    VAPictureH264 *pRefList = NULL;
    uint32 i = 0, j = 0, k = 0, list = 0;

    MixVideoFormat_H264 *self = MIX_VIDEOFORMAT_H264(mix);

    //Set the surface ID for everything in the parser DPB to INVALID
    for (i = 0; i < 16; i++)
    {
        pic_params->ReferenceFrames[i].picture_id = VA_INVALID_SURFACE;
        pic_params->ReferenceFrames[i].frame_idx = -1;
        pic_params->ReferenceFrames[i].TopFieldOrderCnt = -1;
        pic_params->ReferenceFrames[i].BottomFieldOrderCnt = -1;
        pic_params->ReferenceFrames[i].flags = VA_PICTURE_H264_INVALID;  //assuming we don't need to OR with existing flags
    }

    pic_params->num_ref_frames = 0;

    for (i = 0; i < pic_data->num_slices; i++)
    {

        //Copy from the List0 and List1 surface IDs
        pRefList = pic_data->slc_data[i].slc_parms.RefPicList0;
        for (list = 0; list < 2; list++)
        {
            for (j = 0; j < 32; j++)
            {
                if (pRefList[j].flags & VA_PICTURE_H264_INVALID)
                {
                    break;  //no more valid reference frames in this list
                }
                found = FALSE;
                for (k = 0; k < pic_params->num_ref_frames; k++)
                {
                    if (pic_params->ReferenceFrames[k].TopFieldOrderCnt == pRefList[j].TopFieldOrderCnt)
                    {
                        ///check for complementary field
                        tflags = pic_params->ReferenceFrames[k].flags | pRefList[j].flags;
                        //If both TOP and BOTTOM are set, we'll clear those flags
                        if ((tflags & VA_PICTURE_H264_TOP_FIELD) &&
                                (tflags & VA_PICTURE_H264_TOP_FIELD))
                            pic_params->ReferenceFrames[k].flags = VA_PICTURE_H264_SHORT_TERM_REFERENCE;
                        found = TRUE;  //already in the DPB; will not add this one
                        break;
                    }
                }
                if (!found)
                {
                    uint poc = mix_videofmt_h264_get_poc(&(pRefList[j]));
                    void* video_frame = j_hash_table_lookup(self->dpb_surface_table, (void*)poc);

#ifdef DECODER_ROBUSTNESS
                    if (!video_frame)
                    {
                        if (!self->last_decoded_frame)
                        {
                            //No saved reference frame, can't recover this one
                            return MIX_RESULT_DROPFRAME;
                        }

                        pic_params->ReferenceFrames[pic_params->num_ref_frames].picture_id =
                            ((MixVideoFrame *)self->last_decoded_frame)->frame_id;
                        LOG_V( "Reference frame not found, substituting %d\n", pic_params->ReferenceFrames[pic_params->num_ref_frames].picture_id);

                    }
                    else
                    {
                        pic_params->ReferenceFrames[pic_params->num_ref_frames].picture_id =
                            ((MixVideoFrame *)video_frame)->frame_id;
                    }
#else
                    if (!video_frame) return MIX_RESULT_DROPFRAME; //return non-fatal error

                    pic_params->ReferenceFrames[pic_params->num_ref_frames].picture_id =
                        ((MixVideoFrame *)video_frame)->frame_id;
#endif

                    LOG_V( "Inserting frame id %d into DPB\n", pic_params->ReferenceFrames[pic_params->num_ref_frames].picture_id);

                    pic_params->ReferenceFrames[pic_params->num_ref_frames].flags =
                        pRefList[j].flags;
                    pic_params->ReferenceFrames[pic_params->num_ref_frames].frame_idx =
                        pRefList[j].frame_idx;
                    pic_params->ReferenceFrames[pic_params->num_ref_frames].TopFieldOrderCnt =
                        pRefList[j].TopFieldOrderCnt;
                    pic_params->ReferenceFrames[pic_params->num_ref_frames++].BottomFieldOrderCnt =
                        pRefList[j].BottomFieldOrderCnt;
                }

            }
            pRefList = pic_data->slc_data[i].slc_parms.RefPicList1;
        }

    }
    return MIX_RESULT_SUCCESS;
}
#endif

MIX_RESULT MixVideoFormat_H264::_handle_ref_frames(
    VAPictureParameterBufferH264* pic_params,
    MixVideoFrame * current_frame) {

    uint poc = 0;
    LOG_V( "Begin\n");

    if (current_frame == NULL || pic_params == NULL) {
        LOG_E( "Null pointer passed in\n");
        return MIX_RESULT_NULL_PTR;
    }

    LOG_V( "Pic_params has flags %d, topfieldcnt %d, bottomfieldcnt %d.  Surface ID is %d\n",
           pic_params->CurrPic.flags, pic_params->CurrPic.TopFieldOrderCnt,
           pic_params->CurrPic.BottomFieldOrderCnt, (int) current_frame->frame_id);

#ifdef MIX_LOG_ENABLE
    if (pic_params->CurrPic.flags & VA_PICTURE_H264_INVALID)
        LOG_V( "Flags show VA_PICTURE_H264_INVALID\n");

    if (pic_params->CurrPic.flags & VA_PICTURE_H264_TOP_FIELD)
        LOG_V( "Flags show VA_PICTURE_H264_TOP_FIELD\n");

    if (pic_params->CurrPic.flags & VA_PICTURE_H264_BOTTOM_FIELD)
        LOG_V( "Flags show VA_PICTURE_H264_BOTTOM_FIELD\n");

    if (pic_params->CurrPic.flags & VA_PICTURE_H264_SHORT_TERM_REFERENCE)
        LOG_V( "Flags show VA_PICTURE_H264_SHORT_TERM_REFERENCE\n");

    if (pic_params->CurrPic.flags & VA_PICTURE_H264_LONG_TERM_REFERENCE)
        LOG_V( "Flags show VA_PICTURE_H264_LONG_TERM_REFERENCE\n");
#endif

    //First we need to check the parser DBP against our DPB table
    //So for each item in our DBP table, we look to see if it is in the parser DPB
    //If it is not, it gets unrefed and removed
#ifdef MIX_LOG_ENABLE
    uint num_removed =
#endif
        j_hash_table_foreach_remove(this->dpb_surface_table, mix_videofmt_h264_check_in_DPB, pic_params);

    LOG_V( "%d entries removed from DPB surface table at this frame\n", num_removed);


    MixVideoFrame *mvf = NULL;
    //bool found = FALSE;
    //Set the surface ID for everything in the parser DPB
    int i = 0;
    for (; i < 16; i++) {
        if (!(pic_params->ReferenceFrames[i].flags & VA_PICTURE_H264_INVALID)) {
            poc = mix_videofmt_h264_get_poc(&(pic_params->ReferenceFrames[i]));
            LOG_V( "Looking up poc %d in dpb table\n", poc);
            //found = j_hash_table_lookup_extended(this->dpb_surface_table, (void*)poc, NULL, (void**)&mvf);
            mvf = (MixVideoFrame*)j_hash_table_lookup( this->dpb_surface_table, (void *)poc);
            if (NULL != mvf) {
                pic_params->ReferenceFrames[i].picture_id = mvf->frame_id;
                LOG_V( "Looked up poc %d in dpb table found frame ID %d\n", poc, (int)mvf->frame_id);
            } else {
                LOG_V( "Looking up poc %d in dpb table did not find value\n", poc);
            }
            LOG_V( "For poc %d, set surface id for DPB index %d to %d\n",
                   poc, i, (int)pic_params->ReferenceFrames[i].picture_id);
        }
    }
    //Set picture_id for current picture
    pic_params->CurrPic.picture_id = current_frame->frame_id;

    //Check to see if current frame is a reference frame
    if ((pic_params->CurrPic.flags & VA_PICTURE_H264_SHORT_TERM_REFERENCE) ||
            (pic_params->CurrPic.flags & VA_PICTURE_H264_LONG_TERM_REFERENCE)) {
        //Get current frame's POC
        poc = mix_videofmt_h264_get_poc(&(pic_params->CurrPic));
        //Increment the reference count for this frame
        mix_videoframe_ref(current_frame);
        LOG_V( "Inserting poc %d, surfaceID %d\n", poc, (int)current_frame->frame_id);
        //Add this frame to the DPB surface table
        j_hash_table_insert(this->dpb_surface_table, (void*)poc, current_frame);
    }

    LOG_V( "End\n");
    return MIX_RESULT_SUCCESS;
}

MIX_RESULT MixVideoFormat_H264::_cleanup_ref_frame(
    VAPictureParameterBufferH264* pic_params, MixVideoFrame * current_frame) {

    uint poc = 0;
    LOG_V( "Begin\n");

    if (current_frame == NULL || pic_params == NULL) {
        LOG_E( "Null pointer passed in\n");
        return MIX_RESULT_NULL_PTR;
    }

    LOG_V( "Pic_params has flags %d, topfieldcnt %d, bottomfieldcnt %d.  Surface ID is %d\n",
           pic_params->CurrPic.flags, pic_params->CurrPic.TopFieldOrderCnt,
           pic_params->CurrPic.BottomFieldOrderCnt, (int) current_frame->frame_id);

    //Check to see if current frame is a reference frame
    if ((pic_params->CurrPic.flags & VA_PICTURE_H264_SHORT_TERM_REFERENCE) ||
            (pic_params->CurrPic.flags & VA_PICTURE_H264_LONG_TERM_REFERENCE)) {
        //Get current frame's POC
        poc = mix_videofmt_h264_get_poc(&(pic_params->CurrPic));
        //We don't need to decrement the ref count for the video frame here; it's done elsewhere
        LOG_V( "Removing poc %d, surfaceID %d\n", poc, (int)current_frame->frame_id);
        //Remove this frame from the DPB surface table
        j_hash_table_remove(this->dpb_surface_table, (void*)poc);
    }
    LOG_V( "End\n");
    return MIX_RESULT_SUCCESS;
}

uint mix_videofmt_h264_get_poc(VAPictureH264 *pic) {
    if (pic == NULL)
        return 0;

    if (pic->flags & VA_PICTURE_H264_BOTTOM_FIELD)
        return pic->BottomFieldOrderCnt;

    if (pic->flags & VA_PICTURE_H264_TOP_FIELD)
        return pic->TopFieldOrderCnt;

    return pic->TopFieldOrderCnt;

}


int mix_videofmt_h264_check_in_DPB(
    void* key, void* value, void* user_data) {
    int ret = (!0);
    if ((value == NULL) || (user_data == NULL))  //Note that 0 is valid value for key
        return 0;

    VAPictureH264* vaPic = NULL;
    int i = 0;
    for (; i < 16; i++)
    {
        vaPic = &(((VAPictureParameterBufferH264*)user_data)->ReferenceFrames[i]);
        if (vaPic->flags & VA_PICTURE_H264_INVALID)
            continue;

        if ((uint)key == vaPic->TopFieldOrderCnt ||
                (uint)key == vaPic->BottomFieldOrderCnt)
        {
            ret = 0;
            break;
        }
    }
    return ret;
}


void mix_videofmt_h264_destroy_DPB_key(void* data)
{
    //TODO remove this method and don't register it with the hash table foreach call; it is no longer needed
    LOG_V( "Begin, poc of %d\n", (uint)data);
    LOG_V( "End\n");
    return;
}

void mix_videofmt_h264_destroy_DPB_value(void* data)
{
    LOG_V( "Begin\n");
    if (data != NULL) {
        mix_videoframe_unref((MixVideoFrame *)data);
    }
    LOG_V( "End\n");
    return;
}