| commit | d22366d59a46aa16aa79d1d691cd5cb55f56c378 | [log] [tgz] |
|---|---|---|
| author | Ian Lake <ilake@google.com> | Tue Oct 24 22:23:47 2023 +0000 |
| committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | Thu Oct 26 00:48:11 2023 +0000 |
| tree | 65e49d56b99270833e1376e1fa32b83264559040 | |
| parent | 69daaf725f330cb95013409211f2ba77abd919dc [diff] |
Improve the performance of NavGraph.equals() When comparing two graphs, as few allocations should be done as possible and the comparision should short circuit as much as possible. By adding if (this === other) checks, we can short circuit the exact same objects. By using NavDestination's private _arguments field rather than the public, immutable copy provided by arguments, we can avoid copying the arguments multiple times. Since we check whether the size of the arguments are the same, we can avoid iterating through both lists since one list matching means they are identical. We can use Kotlin's built in equals() for Lists to compare deep links rather than using intersect() since ordering *does* matter here when determining a matching deep link. NavGraph does not to create a copy of its children just to remove them, we can instead just iterate through each child and verify that the same child exists in the other graph. Relnote: "Greatly improved the performance (both in terms of time and number of allocations) of comparing two graph. This means that calls such as `setGraph` which internally compare the new graph to the existing one are much faster and result in fewer skipped frames." Test: Benchmark improved (2k ns from 77k ns, 10 allocations from 1,324) BUG: 307253895 (cherry picked from https://android-review.googlesource.com/q/commit:06f18f70d5bffa981332fee3ab0973d26c852828) Merged-In: I6ad62bef1fb9bbbe8a91839a6e24e1f85a8982e2 Change-Id: I6ad62bef1fb9bbbe8a91839a6e24e1f85a8982e2
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.
