Fix memory leak when observing derived state objects

When observing derived state objects, if the recompose snapshot changed
id it caused the derived state objects no longer observed by composition
to be retained by the recompose scope, causing them to leak. The
snapshot id would change if the read is the first time a derived state
object is read in the snapshot.

To detect when a derived state object is no longer necessary a token
value is used to record when the derived state was added into the
composition. This token was the current snapshot id. However, since
the id is not static through-out composition, this could cause the
notification to be skipped.

This change fixes the token to be the snapshot id at the beginning of
composition and, after that, ignores the snapshot id. This means the
token is consistent through-out the same composition allowing unused
derived object to be detected.

Fixes 230168389
Test: new test, ./gradlew :compose:r:r:tDUT

Change-Id: I877c826764592a7e424667d3e2b677d385cf0b7f
4 files changed
tree: 1f0adcb084a733bc23571f5cbed6b43895be5d0e
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. annotation/
  6. appcompat/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. biometric/
  13. browser/
  14. buildSrc/
  15. buildSrc-tests/
  16. busytown/
  17. camera/
  18. car/
  19. cardview/
  20. collection/
  21. collection2/
  22. compose/
  23. concurrent/
  24. contentpager/
  25. coordinatorlayout/
  26. core/
  27. cursoradapter/
  28. customview/
  29. datastore/
  30. development/
  31. docs/
  32. docs-public/
  33. docs-tip-of-tree/
  34. documentfile/
  35. draganddrop/
  36. drawerlayout/
  37. dynamicanimation/
  38. emoji/
  39. emoji2/
  40. enterprise/
  41. exifinterface/
  42. external/
  43. fakeannotations/
  44. fragment/
  45. frameworks/
  46. glance/
  47. gradle/
  48. gridlayout/
  49. health/
  50. heifwriter/
  51. hilt/
  52. ink/
  53. inspection/
  54. interpolator/
  55. jetifier/
  56. leanback/
  57. lifecycle/
  58. lint-checks/
  59. lint-demos/
  60. loader/
  61. media/
  62. media2/
  63. mediarouter/
  64. metrics/
  65. navigation/
  66. paging/
  67. palette/
  68. percentlayout/
  69. placeholder-tests/
  70. playground-common/
  71. preference/
  72. print/
  73. profileinstaller/
  74. recommendation/
  75. recyclerview/
  76. remotecallback/
  77. resourceinspection/
  78. room/
  79. samples/
  80. savedstate/
  81. security/
  82. sharetarget/
  83. slice/
  84. slidingpanelayout/
  85. sqlite/
  86. startup/
  87. swiperefreshlayout/
  88. temp/
  89. test/
  90. testutils/
  91. text/
  92. tracing/
  93. transition/
  94. tvprovider/
  95. vectordrawable/
  96. versionedparcelable/
  97. viewpager/
  98. viewpager2/
  99. wear/
  100. webkit/
  101. window/
  102. work/
  103. .gitignore
  104. .mailmap
  105. build.gradle
  110. gradlew
  111. include-composite-deps.gradle
  112. libraryversions.toml
  113. LICENSE.txt
  114. OWNERS
  115. PREUPLOAD.cfg
  117. settings.gradle
  118. studiow

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password:

Agree to the Google Contributor Licenses Agreement:

Getting reviewed

  • After you run repo upload, open
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.