commit c6a5e51cfaa0f49450b336bbf395dec26e11a1c5
author Mikhail Naganov <mnaganov@google.com> Fri Jul 31 17:44:28 2020 -0700
committer Eric Laurent <elaurent@google.com> Mon Dec 14 09:54:02 2020 +0000
tree 6459a22cdf76a6e5325f21d9073c2b40f70575bd
parent a55b24ba245e2e648b19dfb6e918abb0a2df8648

Update client code for AudioEffect

AudioEffect was fixed to remove a call to AudioEffect::set
away from the constructor.

Bug: 162323621
Bug: 174222126

Test: repro steps from the bug
      atest android.media.cts.VisualizerTest
Change-Id: I355fc9a174a87e682ad870d7c73c1403cdb156ab
Merged-In: I355fc9a174a87e682ad870d7c73c1403cdb156ab

src/jni/rtp/AudioGroup.cpp

diff --git a/src/jni/rtp/AudioGroup.cpp b/src/jni/rtp/AudioGroup.cpp
index 51b723d..5f9cae8 100644
--- a/src/jni/rtp/AudioGroup.cpp
+++ b/src/jni/rtp/AudioGroup.cpp
@@ -851,14 +851,14 @@
     sp<AudioEffect> aec;
     if (mode == ECHO_SUPPRESSION) {
         if (mGroup->platformHasAec()) {
-            aec = new AudioEffect(FX_IID_AEC,
-                                    mGroup->mOpPackageName,
-                                    NULL,
-                                    0,
-                                    0,
-                                    0,
-                                    record->getSessionId(),
-                                    AUDIO_IO_HANDLE_NONE); // record sessionId is sufficient.
+            aec = new AudioEffect(mGroup->mOpPackageName);
+            aec->set(FX_IID_AEC,
+                     NULL,
+                     0,
+                     0,
+                     0,
+                     record->getSessionId(),
+                     AUDIO_IO_HANDLE_NONE); // record sessionId is sufficient.
             status_t status = aec->initCheck();
             if (status == NO_ERROR || status == ALREADY_EXISTS) {
                 aec->setEnabled(true);