tree 712c4ff7ab34f5b02b9bbf5c7467ff1ae02e2d7a
parent 793e8792a20b61c470b4f578a30ccfedfef482a9
author David Brazdil <dbrazdil@google.com> 1671487105 +0000
committer David Brazdil <dbrazdil@google.com> 1671493756 +0000

rpc_binder: Prevent RpcServer shutdown deadlock

RpcServer::~RpcServer invokes shutdown() to trigger exit from all
join and session threads. The function waits for the number of
connections to drop down to zero, but this depends on RpcSession
promoting a wp<RpcServer> to sp<RpcServer>. Since this is happening
during the destructor, when the refcount is zero, this pointer
promotion fails. As a result, the list of connections may not be fully
cleared and the thread calling shutdown() will deadlock.

Fix this by forcing users to call shutdown() earlier and panicing
otherwise.

Bug: 263168076
Test: cleanly shutdown RpcServer with many connections
Change-Id: Ia67a4a839419aafb1bd47fb93ed2e76d56b107c2