0cda11569d - platform/frameworks/native

commit: 0cda11569dd256ff3220b4fe44f861f8081d7116
[log]
author: sergiuferentz <sergiuferentz@google.com>
Mon Jun 26 18:01:47 2023 +0000
committer: Android Build Coastguard Worker <android-build-coastguard-worker@google.com>
Thu Aug 10 17:11:52 2023 +0000
tree: 76c88564d59b51976e524a8eb2a394c269786e01
parent: 686a75e8cd7a20c613dca5fec9d5a7877d360bac [diff]

Fix for heap-use-after-free in GPUService.cpp

This adds a unit test and fix for the bug reported by libfuzzer.
Changes made:
 * Expose GPUService as testable code.
 * Update main_gpuservice.cpp to use the new GpuService now located at
   gpuservice/GpuService.h
 * Make initializer threads members of GpuService
 * Join the threads in destructor to prevent heap-use-after-free.
 * Add unit test that waits 3 seconds after deallocation to ensure no
   wrong access is made.

Bug: 282919145
Test: Added unit test and ran on device with ASAN
(cherry picked from commit 3c00cbc0f119c3f59325aa6d5061529feb58462b)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7fb707802ee4c667d1ee6065ae2845d835b47aeb)
Merged-In: I4d1d2d4658b575bf2c8f425f91f68f03114ad029
Change-Id: I4d1d2d4658b575bf2c8f425f91f68f03114ad029

services/gpuservice/Android.bp[diff]
services/gpuservice/GpuService.cpp[diff]
services/gpuservice/include/gpuservice/GpuService.h[Renamed from services/gpuservice/GpuService.h - diff]
services/gpuservice/main_gpuservice.cpp[diff]
services/gpuservice/tests/unittests/Android.bp[diff]
services/gpuservice/tests/unittests/GpuServiceTest.cpp[Added - diff]

6 files changed

tree: 76c88564d59b51976e524a8eb2a394c269786e01