tag 5daaf49af5b6d9e2497bda96d1a236f6dd99ddc2
tagger The Android Open Source Project <initial-contribution@android.com> Thu Apr 23 11:14:29 2020 -0700
object 029a7f0dc038e002087fd9846873aa08c51c2d86

Android R Preview 3 (RPP3.200320.017)

commit 029a7f0dc038e002087fd9846873aa08c51c2d86
author Lorenzo Colitti <lorenzo@google.com> Mon Mar 02 19:24:15 2020 +0900
committer Lorenzo Colitti <lorenzo@google.com> Tue Mar 17 01:39:56 2020 +0900
tree 61b0708359bfb6f0fd6e25e19db58c3fff795e05
parent 33e2ff80842b917b95992623e39a13be743838b3

Make NetworkFactory a single-use object.

Currently, when bluetooth tethering is disabled, the bluetooth
process crashes because unregister() calls setScoreFilter() and
immediately nulls out mProvider. This crashes as soon as the
message posted by setScoreFilter() dereferences mProvider from
the handler thread.

This sort of teardown problem is very difficult to fix given
NetworkFactory's threading model where some code runs on the
handler thread and some code runs on whatever thread calls it.
Instead of complicating the code to do this, simply make it
impossible to call register() after having called unregister().
The only factory that does so today is bluetooth tethering, and
that can be trivially modified to create and register a new
factory instead.

This CL renames the unregister() method to terminate() in order
to make it clear that the object cannot be reused, and also to
ensure that no other code in the tree is unexpectedly calling
unregister().

Bug: 148635501
Test: atest FrameworksNetTests
Change-Id: Icf4c7a957e46e4ba017c0a5984e5c42a75b36ecd
Merged-In: Icf4c7a957e46e4ba017c0a5984e5c42a75b36ecd