tree 04b6bcfb34cc5e79e4a7e8e9a1d880796dbc38bb
parent c2a76f90a8caf6319e4105bc648f1d7896bff9a7
author Pinyao Ting <pinyaoting@google.com> 1626478120 +0000
committer Pinyao Ting <pinyaoting@google.com> 1626478412 +0000

Refrain from returning mutable pending intent in getShortcutIntent

Mutable PendingIntent leads to potential security vulnerabilities, this
CL makes the returning PendingIntent immutable | update current. The
recipeint cannot change the content of the PendingIntent directly, but
the owner can still update the extras of the PendingIntent.

Note: PendingIntent is internally cached in PendingIntentController, so
the owner process do have access to the PendingIntent since
LauncherAppServices called
ActivityManagerService#getPendingIntentActivityAsApp to retrieve the
PendingIntent.

Bug: 190732424
Test: atest ShortcutManagerClientApiTest
Change-Id: Ife8ad7824f061e9e20d31c96f76ceed4edb547cd