tree 46b9901f752eef22275df775ad0418803b82f113
parent 5f621b5b1549e8379aee05807652d5111382ccc6
author Svetoslav Ganov <svetoslavganov@google.com> 1482275726 -0800
committer gitbuildkicker <android-build@google.com> 1484872377 -0800

[DO NOT MERGE] Prevent crash from early Toast surface destruction.

To understand this change it's first helpful to review Toasts.
The ViewRoot is constructed on the client side, but it's added,
to a window token controlled by the NotificationManagerService.
When we call NotificationManagerService#cancelToast, the system
will remove this window token. With the window token removed,
the WindowManager needs to destroy the surface to prevent orphaned
windows. If we destroy the Surface before removing the toast on the
client side however, we've never asked the ViewRoot to stop rendering
and we could have a crash. To solve this we just have to ensure we call
removeView before cancelToast.

Bug: 31547288
Bug: 30150688

Change-Id: Ic7e8914a7fb2134a8b9e0c2f3810d7f075c8391e
(cherry picked from commit 016c9c8cb58c6940ae8296291ee33148a17ede65)