e8c548fd0221 - platform/frameworks/base

commit	e8c548fd0221ccb181fd8c5864783f68cd799593	[log] [tgz]
author	Benedict Wong <benedictwong@google.com>	Thu Jul 15 19:41:53 2021 -0700
committer	Benedict Wong <benedictwong@google.com>	Fri Jul 16 12:10:08 2021 -0700
tree	0e81eb2baa6d116765713c916366857b750ab46a
parent	9ffdbe8b2a47a56b9ffb5791d2ef64b75dac1bac [diff]

Ensure VcnGatewayConnection#isQuitting never gets unset after being set

This change ensures that the VcnGatewayConnection can never abort a
quitting command; specifically, if a non-quitting disconnect request is
processed after a quitting disconnect request, the isQuitting value MUST
continue to stay set (as true).

Failure to OR the values results in orphaned VcnGatewayConnection(s),
and the VCN network thrashing.

Additionally reduce verbosity of local logs, to ensure it better
captures failures and logWtf(s)

Bug: 192776413
Test: atest FrameworksVcnTests
Change-Id: Iec8dae701838794261957609bae4e270eaa9cdc7

services/core/java/com/android/server/VcnManagementService.java[diff]
services/core/java/com/android/server/vcn/Vcn.java[diff]
services/core/java/com/android/server/vcn/VcnGatewayConnection.java[diff]
services/core/java/com/android/server/vcn/util/OneWayBoolean.java[Added - diff]
tests/vcn/java/com/android/server/vcn/VcnGatewayConnectionConnectedStateTest.java[diff]
tests/vcn/java/com/android/server/vcn/VcnGatewayConnectionConnectingStateTest.java[diff]
tests/vcn/java/com/android/server/vcn/VcnGatewayConnectionDisconnectedStateTest.java[diff]
tests/vcn/java/com/android/server/vcn/VcnGatewayConnectionDisconnectingStateTest.java[diff]
tests/vcn/java/com/android/server/vcn/VcnGatewayConnectionRetryTimeoutStateTest.java[diff]

9 files changed