commit d2f8a65c9bce335ab556f386f9bc64fe6b323c8c
author Pinyao Ting <pinyaoting@google.com> Tue Mar 30 14:34:04 2021 -0700
committer android-build-team Robot <android-build-team-robot@google.com> Thu Apr 01 00:12:12 2021 +0000
tree f53528317760a9d505a70566da7d442af6aef073
parent 84abc66ffe736a53ddee4a2fd65df7796071c147

Fixes an issue in shortcut persistence.

Currently after reboot the shortcuts previously saved in AppSearch could
be lost since ShortcutService never calls AppSearchSession#close.
Closing the session upon device shutdown fixes the issue.

Also, removes the exception where calling AppSearchSession#close gives
rise to IllegalArgumentException when the call wasn't made from a binder
thread. Since ShortcutService runs in the system process, it is expected
that calling AppSearchSession#close doesn't goes through binder.

Bug: 183982287
Test: flash, pin shortcuts, reboot, observe
Test: atest ShortcutManagerTest1 ShortcutManagerTest2
ShortcutManagerTest3 ShortcutManagerTest4 ShortcutManagerTest5
ShortcutManagerTest6 ShortcutManagerTest7 ShortcutManagerTest8
ShortcutManagerTest9 ShortcutManagerTest10 ShortcutManagerTest11
Test: atest CtsShortcutManagerTestCases

Change-Id: I61bc4354735770630965ca4f81314d23671165d0
(cherry picked from commit 4dedfc8ba3d8654d9cbf006101770e2ee4331837)