Google Git
Sign in
android / platform / frameworks / base / cfb9e6179bb6
commitcfb9e6179bb64799faa36df1ebdccf941fdf194c[log] [tgz]
authorPablo Gamito <pablogamito@google.com>Fri Jun 13 03:29:31 2025 -0700
committerPablo Gamito <pablogamito@google.com>Fri Jun 13 15:11:14 2025 +0000
treec91f6f41e55253771b3e70f4d96f9ae7f09949d5
parentd09238d4d613ae83810b7dba98c9ceea7e90caec [diff]
Snapshot mutable ProtoLog arguments before sending them to the background thread

Before this CL, the args where passed as they were to the background thread. This means that if they were modified after the call to the log function, then there might be a race condition and even crashes due to concurrent accesses.

This CL fixes that by copying the values by calling toString() on every object before passing them to the background thread.

Test: atest TracingTests
Bug: 420430923
Flag: EXEMPT bug fix
Change-Id: Ide20527b4b1406ffb0979fb35aab861a98260297
2 files changed
tree: c91f6f41e55253771b3e70f4d96f9ae7f09949d5
  1. .prebuilt_info/
  2. android-sdk-flags/
  3. apct-tests/
  4. apex/
  5. api/
  6. boot/
  7. cmds/
  8. config/
  9. core/
  10. data/
  11. docs/
  12. drm/
  13. errorprone/
  14. graphics/
  15. identity/
  16. keystore/
  17. libs/
  18. location/
  19. media/
  20. mime/
  21. mms/
  22. native/
  23. nfc-extras/
  24. nfc-non-updatable/
  25. obex/
  26. omapi/
  27. opengl/
  28. packages/
  29. proto/
  30. ravenwood/
  31. rs/
  32. samples/
  33. sax/
  34. services/
  35. startop/
  36. telecomm/
  37. telephony/
  38. test-base/
  39. test-junit/
  40. test-legacy/
  41. test-mock/
  42. test-runner/
  43. tests/
  44. tools/
  45. vendor/
  46. wifi/
  47. .clang-format
  48. .gitignore
  49. .mailmap
  50. AconfigFlags.bp
  51. ACTIVITY_MANAGER_OWNERS
  52. ACTIVITY_SECURITY_OWNERS
  53. ADPF_OWNERS
  54. Android.bp
  55. BAL_OWNERS
  56. BATTERY_STATS_OWNERS
  57. BROADCASTS_OWNERS
  58. CleanSpec.mk
  59. FF_LEADS_OWNERS
  60. framework-jarjar-rules.txt
  61. GAME_MANAGER_OWNERS
  62. INPUT_OWNERS
  63. INTENT_OWNERS
  64. libcore-readonly.aconfig
  65. lint-baseline.xml
  66. LSE_APP_COMPAT_OWNERS
  67. MEMORY_OWNERS
  68. MESSAGE_QUEUE_OWNERS
  69. METADATA
  70. MODULE_LICENSE_APACHE2
  71. MULTIUSER_OWNERS
  72. NOTICE
  73. OOM_ADJUSTER_OWNERS
  74. OWNERS
  75. OWNERS.md
  76. PACKAGE_MANAGER_OWNERS
  77. pathmap.mk
  78. PERFETTO_OWNERS
  79. PERFORMANCE_OWNERS
  80. PREUPLOAD.cfg
  81. PREUPLOAD_OWNERS
  82. ProtoLibraries.bp
  83. Ravenwood.bp
  84. SDK_OWNERS
  85. SECURITY_STATE_OWNERS
  86. SQLITE_OWNERS
  87. TEST_MAPPING
  88. TestProtoLibraries.bp
  89. THERMAL_OWNERS
  90. TRACE_OWNERS
  91. TRADE_IN_MODE_OWNERS
  92. WEAR_OWNERS
  93. ZYGOTE_OWNERS