tree 9fcc676c008a9f06cb2fd06abd1e07be21cbcdef
parent ba64286afc758d5920f5689e00ddc0ff88be1903
author Vishnu Nair <vishnun@google.com> 1630360889 -0700
committer Android Build Coastguard Worker <android-build-coastguard-worker@google.com> 1631638820 +0000

Surface: Release references to BlastBufferQueue and SurfaceControl on Surface#destroy

SurfaceView clients may hold on to surface references. In S this means
they would extend the lifetime of the SurfaceControl resulting in
"leaking" buffers until the references are cleared or the app is
terminated.

Fix this by calling a new destroy function on Surface which will
explicitly remove references to the SurfaceControl and BBQ it holds.
This is safe because SurfaceView controls the lifecycle of the Surface
and knows when the Surface will become invalid. Once invalid, the Surface
cannot become valid again.

Test: repro steps in bug
Bug: 198133921
Change-Id: I5c7e43736f025fc0965eae2f19719ba40df3cb70
Merged-In: I5c7e43736f025fc0965eae2f19719ba40df3cb70
(cherry picked from commit 43b0f37a70b36e0dd3b47352d3b5ecdd594e1551)