tree 40c7663a2e7d3a1d21f752e51a5d01bb818a6c73
parent 9f62ea551f70573a284a4f64ec5635616e28529a
author Matt Pietal <mpietal@google.com> 1633100596 -0400
committer Android Build Coastguard Worker <android-build-coastguard-worker@google.com> 1647368189 +0000

Keyguard - Treat messsages to lock with priority

When switching users and attempting to lock the device, the sysui main
thread becomes overwhelmed with events, creating a significant lag
between the time a message is posted and processed on the main
thread. This can be dangerous when these events are critical for
security, such as calls coming from PhoneWindowManager#lockNow() that
call KeyguardViewMediator#doKeyguardTimeout(). On older devices with
slower CPUs and less memory, the delay in processing can be
significant (15 - 30s).

The result of not prioritizing these events leads to a window of time
where a guest user can switch back to the owner, and gain access to
the owner's homescreen without needing to unlock the device with the
owner's credentials.

As a mitigation, prioritize two events originating in two specific
methods to make sure the device locks as soon as possible as well as
have the system server preemptively update its local cache.

Bug: 151095871
Test: Very manual race condition - follow steps listed in bug
Change-Id: I7585a0a5eeb308e0e32a4f77f581556d883b5cda
Merged-In: I7585a0a5eeb308e0e32a4f77f581556d883b5cda
(cherry picked from commit 28c53ab8bca26af58b45625c1ebba8b9051c107d)
(cherry picked from commit f8023c9829890ede1bdcbd04314d26c122b1f3f1)
(cherry picked from commit 256b5f08a89e441f7e01f87346945e9350fa7a3c)
Merged-In: I7585a0a5eeb308e0e32a4f77f581556d883b5cda